Reuse the crafting job toast from IntegratedTerminals - #17
Merged
Conversation
The toast was generalized and moved to IntegratedTerminals, so that both mods show the same kind of notification. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QNDY2pZtkXqJrhztYCvNbh
This build contains the shared crafting job toast, which now draws its icon through the ingredient component's terminal storage handler, so the summary toast passes its status icon as an item stack ingredient. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QNDY2pZtkXqJrhztYCvNbh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to CyclopsMC/IntegratedTerminals#214, which generalizes
CraftingJobToastand moves it to IntegratedTerminals so that both mods show the same kind of notification.Important
CI will fail until that PR is merged and released, and
integratedterminals_versionis bumped ingradle.properties.What
CraftingJobToastand itstoast/crafting_jobsprite, which now live in IntegratedTerminals.TerminalStorageIngredientCraftingJobErrorToastPacketuses the IntegratedTerminals class instead. The toast now takes an arbitrary grouping token, so theSUCCESS/FAILURE/MIXEDslot enum moves into the packet as a privateToastType.No behaviour changes: the auto-craft summaries look and group exactly as before.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QNDY2pZtkXqJrhztYCvNbh
Generated by Claude Code