Repository navigation
Fix state tracking for sequenced triggers. Improve logging - #522
Merged
Merged
Conversation
the building and writing states.
…numbers are okay to ignore/not raise errors or warnings
…t/stop instead of conf/scrap
eflumerf
marked this pull request as draft
November 5, 2026 17:48
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
… for stale run DataflowStatus message, silently allowing it if it is from the previous run and there are no open triggers
…to stop retrying RetryableDataStoreProblem exceptions
Member
Author
|
Output from |
eflumerf
marked this pull request as ready for review
November 6, 2026 19:33
wesketchum
approved these changes
Nov 9, 2026
wesketchum
left a comment
Contributor
There was a problem hiding this comment.
I've tested and I also see that the tests are passing (modulo connectivity service issues) that aren't the dfo_protocol_test.
(Identified maybe a separate issue when trying to run the dfo_protocol_test here: #526. Still working on closing the loop on that.)
So, looks ok to me and I think it will help with tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the case where TRBModule decides to sequence a trigger decision, DataflowStatusModule needs to be able to allow the trigger to be in both "building" and "writing" states, as early sequences can complete building and writing while later sequences are still being built.
Fix logging in DFOModule::is_busy,
TLOG()will always print logs, even when given a TRACE level.Improve DataflowStatusModule ERS issues, including sequence number and current run number for comparison.
Work on
drain_dataflowandstopcorrectness.drain_dataflowwill now cause DataWriterModule to stop retrying when it encounters a writing issue (e.g. insufficient_disk_space_test). DataflowStatusModule now runs its heartbeat thread from start to stop (instead of conf to scrap).Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)At time of PR creation, integration tests are ongoing.
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))