Skip to content

Run dbt-clang-format.sh - #524

Merged
eflumerf merged 1 commit into
developfrom
eflumerf/ClangFormat
Nov 6, 2026
Merged

eflumerf merged 1 commit into
developfrom
eflumerf/ClangFormat

Conversation

@eflumerf

@eflumerf eflumerf commented Nov 6, 2026

Copy link
Copy Markdown
Member

Description

Simply run dbt-clang-format.sh on dfmodules.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@eflumerf
eflumerf requested a review from jcfreeman2 November 6, 2026 16:13

@jcfreeman2 jcfreeman2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed via dbt-clang-format.sh that whitespace is now on the level.

@eflumerf
eflumerf merged commit 9f2a96c into develop Nov 6, 2026
6 checks passed
@eflumerf
eflumerf deleted the eflumerf/ClangFormat branch November 6, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants