feat(monitors): skip monitors with restricted roles - #672
Open
riyazsh wants to merge 1 commit into
Open
Conversation
riyazsh
force-pushed
the
riyazsh/spans-metrics-409-fallback
branch
from
August 25, 2026 21:09
915ac23 to
7d5f18f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skip-monitors-with-restricted-rolesto the sync commandrestricted_roleswhen the flag is enabledContext
Paxos DDR US1 -> US5 currently has one monitor carrying
restricted_roleswhile the destination role exists with zero effective active users. This causes the monitor API create to fail. The flag gives managed-sync an explicit short-term escape hatch that records the resource as filtered instead of attempting an unsafe create/update.Testing
python -m pytest tests/unit/test_monitors.py