Update codeowners file - #12228
Conversation
d9a19bb to
6b37d5d
Compare
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
Each current top-level path has an explicit owner. The changed product patterns keep or increase the intended test ownership.
🤖 Datadog Autotest · Commit b3e41bd · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
PerfectSlayer
left a comment
There was a problem hiding this comment.
Few suggestions to move tooling under the platform umbrella to avoid product teams having to review them, and reassign few parts to SDK cap too.
Overall, do we need the default catch all for the core modules? Won't it defeat the need to create codeownership entries every time a product will add its features there?
bric3
left a comment
There was a problem hiding this comment.
LGTM
What about adding a cartouche that gives a guide of rules to apply when modifying this file, like using */* for source set and language, etc.
Just a thought, I wonder if it is possible to make lang platform team to co-own with the other responsible team every build.gradle / build.gradle.kts files (maybe others like the lockfiles). From the capabilities of the CODEOWNERS file it can't be done easily without adding a lot of rules.
Yes, that's a good idea consider the amount of effort invested here. |
It makes sense to me to have LP own these files. Whatever module they're in will likely already have the corresponding codeowner team requested for review. This makes the CODEOWNER rules much more straightforward too since it's last write wins. cc @bric3 @PerfectSlayer |
|
Given codeowner review requirements to be enabled on Monday, I'll go ahead with merging this PR. Any subsequent changes can be made in a follow-up PR! |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Update CODEOWNERS file such that
@DataDog/apm-java- there is no longer a default teamMotivation
RFC for "CODEOWNER File Expectations Across dd-trace-* Repositories": https://docs.google.com/document/d/1sRETEtnOf-ewrfuf_eQCs1nL8wbht2N7Dm9m5nrMJ1Y/edit?usp=sharing
Ensure that all code is properly and explicitly owned and protected by teams with the most context in that domain.
Additional Notes
In conjunction with these changes, all-files-are-owned via Datadog’s MergeGate mechanism should be enabled - this ensures that all new and existing files have assigned codeowners, according to the Code Ownership Service
See this CI Opt page to ensure we don't lack test coverage. Note that the remaining files with
UNKNOWNsource files are addressed in #12259.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]