chore(deps): bump dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from aaa97e4 to b647031 - #12231
Conversation
…ystem-test-data Bumps [dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `aaa97e4` to `b647031`. - [Commits](DataDog/ffe-system-test-data@aaa97e4...b647031) --- updated-dependencies: - dependency-name: dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data dependency-version: b6470316cbfb00ad507eee79f5053a6a481a8c3c dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
The bumped fixtures require malformed flags to resolve as ERROR/PARSE_ERROR, but the current evaluator returns DEFAULT for those flags. Both canonical fixture coverage and the OpenFeature smoke test enumerate the affected cases and will fail.
🤖 Datadog Autotest · Commit f00f633 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
| @@ -1 +1 @@ | |||
| Subproject commit aaa97e44bb19c9cee7ae079995ddbcc864c6b702 | |||
| Subproject commit b6470316cbfb00ad507eee79f5053a6a481a8c3c | |||
There was a problem hiding this comment.
Implement the new malformed-flag contract before bumping fixtures
The canonical evaluator fixture test and OpenFeature smoke test will consistently fail when they enumerate the newly updated malformed-flag cases.
Assertion details
- Input: A malformed-flag isolation case introduced by fixture revision b647031, such as a dropped malformed flag expected to produce PARSE_ERROR.
- Expected:
Malformed flags represented by the updated fixtures should return the default value with reason ERROR and errorCode PARSE_ERROR. - Actual:
The parser records malformed flags as invalid_flag, and DDEvaluator returns the default value with Reason.DEFAULT and no error code for them, causing the updated fixture assertions to fail.
Was this helpful? React 👍 or 👎
🤖 Datadog Autotest · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Bumps dd-smoke-tests/openfeature/src/test/resources/ffe-system-test-data from
aaa97e4tob647031.Commits
b647031Merge pull request #21 from DataDog/blake.thomas/FFL-2914-pr0-regex-conforman...8e8a6c2Version narrowed regex contract6c11ed1Narrow portable regex authoring contract3160ea4Clarify targeting regex contract scopeab0a81fci: keep existing downstream drift advisory2c55e32Merge latest main into regex conformance fixturef744cf7Correct targeting regex fixturesea8b5ccMerge pull request #26 from DataDog/agent/variant-type-mismatch-fixturescc2c56atest: clarify malformed flag errorsa2a7c39test: report rejected flags as parse errorsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)