Repository navigation
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 1092181 | Docs | View more details | Give us feedback! |
evalya-impact-summaryEvalya CI impact |
Disk usage changeCommit Uncompressed
Details
Compressed
Details
|
14e5734 to
4017aa7
Compare
Build the generated InstanceConfig model once in __init__, as postgres does, instead of reading loose values from the instance dict. Global custom query merging moves into build_config. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Base metric queries and table space state tracking move to MetricsCollector in metrics.py, and custom query collection moves to CustomMetricsCollector in custom_metrics.py. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Db2Connection owns the ibm_db connection, reconnect-on-failure, and row iteration, and get_connection_data becomes a module-level function. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Submission methods are looked up on the check rather than the collector, which has no gauge/monotonic_count, so every custom metric was being rejected as an invalid submission method. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Switch the test environment to icr.io/db2_community/db2 for 11.5.5.1 and 12.1.5.0. The official image needs privileged mode and an explicit instance password, and creates the instance at startup, so the fixture waits for setup to finish before creating the test database. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Custom queries now run on their own thread and connection, registered with the DatabaseCheck async job lifecycle. The check and the job close their connections on shutdown. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
AAraKKe
left a comment
There was a problem hiding this comment.
Hi team! Some comments below, I understand why you are trying to run tests in GitLab but that is a hard blocker to merge this PR, take a look at the comment about that as the strongest one that I have. I would propose to drop 11.1 al together since it is fully EOL with not even extended support and supporting it in GitLab means not knowing anything about the tests on the integration at all in the standard quality validation checks we currently have.
✅ Dispatcher tests: passed
✅ 10 passed · nothing failed Batches · ✅ batch-01 10/10 Dispatcher finished on |
|
I'm checking out the ACR question both otherwise have addressed the feedback |
|
@AAraKKe I think I've addressed your feedback. There might be a CI flake right now, but if my last commit fixes that it's good to merge. Any chance of a ✅ 😄 ? |
AAraKKe
left a comment
There was a problem hiding this comment.
Lets go! 🚀🚀🚀
Thanks for taking a look, the failed job right now does seem more an issue with the testing harness than anything else because I saw it passing before. I will take a look tomorrow since I am in rotation this week.
Validation ReportAll 22 validations passed. Show details
|
### What does this PR do? Update `go-sqllexer` from v0.2.5 to [v0.2.6](https://github.com/DataDog/go-sqllexer/tree/v0.2.6), which includes the merged [Db2 literal-handling fix](DataDog/go-sqllexer#115). Keep the version and checksums consistent across Agent modules. ### Motivation Db2 treats backslashes as ordinary characters inside string literals. The current lexer treats them as escapes, so `VALUES 'path\', 'secret'` can normalize to `VALUES ? secret ?`, exposing a literal value. With this fix, it becomes `VALUES ?, ?`. This is needed for the [Db2 DBM integration](DataDog/integrations-core#25329) just merged into integrations-core. ### Describe how you validated your changes - Obfuscator suite passed with race detection; `dda inv tidy` passed without additional changes. - A rebuilt Linux/amd64 Agent using the same lexer code passed all 13 native Db2 obfuscation corpus pairs. The v0.2.5 build failed two backslash cases. - Verified the signed v0.2.6 tag resolves through the public Go proxy; it differs from the native-tested commit only by the release changelog. Co-authored-by: jason.petersen <jason.petersen@datadoghq.com>
What does this PR do?
Add opt-in Database Monitoring (
dbm: true) for IBM Db2 LUW:Validation: 49 unit tests passed, along with ddev lint and configuration/model validation. Live Db2 integration and E2E tests were not run locally.
Motivation
This is the first merge of the Db2 DBM development branch into master, bringing query metrics and full query text into the existing IBM Db2 integration. Schema collection remains a separate follow-up in #25330.
Earlier component reviews:
Checklist before requesting review