Repository navigation
Fix patch release backport candidate discovery - #905
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
More details
Space-delimited parsing restores discovery of pending commits while preserving exclusion of patch-equivalent backports. The completed static review and local Git regression coverage support both behaviors.
🤖 Bits Code Review · Commit 9245fbe
CI Test ResultsRun: #40330238935 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-10-26 13:48:40 UTC |
What does this PR do?:
Fixes candidate discovery in
utils/prepare-patch.sh. Adds regression coverage and documents the test command.Motivation:
Patch preparation reported “No commits on main ahead” even when backport candidates existed.
IFS=madereadconsume the entire+ <SHA>line as the sign, so every candidate was discarded. Splitting on spaces restores detection and preserves exclusion of equivalent backports.Additional Notes:
Agentic review: passed — Codex reviewed the full committed change against
origin/mainand found no actionable regressions.Live backport and release execution: inconclusive — not exercised.
How to test the change?:
bash utils/tests/test_prepare_patch.sh: four cases covering equal branches, two pending PRs, a partial backport, and a complete backport.For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.Unsure? Have a question? Request a review!