Skip to content

🍒 Prepare patch: backport 5 PR(s) to release/1.52._ - #906

Merged
kaahos merged 5 commits into
release/1.52._from
paul.fournillon/patch-prep-1.52._
Oct 26, 2026
Merged

kaahos merged 5 commits into
release/1.52._from
paul.fournillon/patch-prep-1.52._

Conversation

@kaahos

@kaahos kaahos commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?:

Backports the following PR(s) to release/1.52._ in preparation for the next patch release:

Motivation:

Prepares the next patch release from release/1.52._ with the selected main-branch fixes and dependency updates.

Additional Notes:

How to test the change?:

  • passed — preparation script build validation, as reported by the author.
  • passed — 33 source-quality test groups during agentic review.
  • passed — macOS native debug tests and source quality checks during agentic review.
  • inconclusive — Linux ELF reachability checks were skipped on macOS; Linux validation remains for CI.

For Datadog employees:

Unsure? Have a question? Request a review!

jbachorik and others added 5 commits October 26, 2026 14:45
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 7.0.0 to 7.1.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@5fda3b9...6d4fd22)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 7.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit bca66bf)
…#901)

Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-23 to 1.5.7-24.
- [Commits](luben/zstd-jni@v1.5.7-23...v1.5.7-24)

---
updated-dependencies:
- dependency-name: com.github.luben:zstd-jni
  dependency-version: 1.5.7-24
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit af25ad3)
Bumps the gradle-minor group with 3 updates: [gradle-wrapper](https://github.com/gradle/gradle), [at.yawk.lz4:lz4-java](https://github.com/yawkat/lz4-java) and org.ow2.asm:asm.

Updates `gradle-wrapper` from 9.8.1 to 9.8.2
- [Release notes](https://github.com/gradle/gradle/releases)
- [Commits](gradle/gradle@v9.8.1...v9.8.2)

Updates `at.yawk.lz4:lz4-java` from 1.12.0 to 1.12.1
- [Release notes](https://github.com/yawkat/lz4-java/releases)
- [Changelog](https://github.com/yawkat/lz4-java/blob/main/CHANGES.md)
- [Commits](yawkat/lz4-java@v1.12.0...v1.12.1)

Updates `org.ow2.asm:asm` from 9.11 to 9.11.1

---
updated-dependencies:
- dependency-name: gradle-wrapper
  dependency-version: 9.8.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gradle-minor
- dependency-name: at.yawk.lz4:lz4-java
  dependency-version: 1.12.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gradle-minor
- dependency-name: org.ow2.asm:asm
  dependency-version: 9.11.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: gradle-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit fe04bd0)
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T14:05:38.971994Z 501dfbc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 501dfbc127

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

r"_ZN15SharedLockGuardC\dEP8SpinLock", r"_ZN18ExclusiveLockGuardC\dEP8SpinLock",
r"_ZN13MutexLockerC\d\w*",
# stdio
r"vsnprintf", r"snprintf", r"fprintf", r"printf", r"fflush", r"fopen",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Track compiler-lowered stdio sinks

When signal-reachable code uses printf("literal\n") or fprintf(stream, "literal\n"), GCC emits puts or fwrite relocations even at the debug build's -O0; neither symbol matches this sink list, so the new CI check can report clean while the handler still executes async-signal-unsafe stdio. Add these compiler-lowered targets to UNSAFE_SINKS and cover them in the fixture.

AGENTS.md reference: AGENTS.md:L173-L193

Useful? React with 👍 / 👎.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: FAIL

The signal-safety CI gate reports clean when GCC lowers unsafe stdio calls to puts, fputs, or fwrite. This confirms the limitation already acknowledged as deferred in the PR description; the localized suggestion detects those calls.

Open Bits AI session

🤖 Bits Code Review · Commit 501dfbc

r"_ZN15SharedLockGuardC\dEP8SpinLock", r"_ZN18ExclusiveLockGuardC\dEP8SpinLock",
r"_ZN13MutexLockerC\d\w*",
# stdio
r"vsnprintf", r"snprintf", r"fprintf", r"printf", r"fflush", r"fopen",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Recognize compiler-lowered stdio calls as unsafe sinks

GCC lowers literal printf/fprintf calls to puts, fputs, or fwrite even at -O0. These symbols are absent from UNSAFE_SINKS: a focused reproduction containing all three relocations returned zero findings from a recognized signal-handler root. Consequently, the new CI gate can accept async-signal-unsafe stdio. Adding these symbols detected every call and preserved the existing fixture expectations. The PR description acknowledges this deferred limitation.

Suggested change
r"vsnprintf", r"snprintf", r"fprintf", r"printf", r"fflush", r"fopen",
r"vsnprintf", r"snprintf", r"fprintf", r"printf", r"fflush", r"fopen",
r"puts", r"fputs", r"fwrite",

React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it

What each reaction means
  • 👍 Useful: correct, and you're fixing it or will.
  • 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
  • 😕 Unclear: you can't tell what it means or why it matters.
  • 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.

🤖 Bits Code Review · Open Bits AI session

@kaahos
kaahos merged commit 5ad3e09 into release/1.52._ Oct 26, 2026
111 of 113 checks passed
@kaahos
kaahos deleted the paul.fournillon/patch-prep-1.52._ branch October 26, 2026 14:36
@dd-octo-sts

dd-octo-sts Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

CI Test Results

Run: #40335746794 | Commit: 0dfb842 | Duration: 22m 2s (longest job)

✅ All 32 test jobs passed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - ✅ - -
8-ibm - ✅ - -
8-j9 ✅ ✅ - -
8-librca - - ✅ ✅
8-orcl - ✅ - -
11 - ✅ - -
11-j9 ✅ ✅ - -
11-librca - - ✅ ✅
17 ✅ ✅ - -
17-graal ✅ ✅ - -
17-j9 ✅ ✅ - -
17-librca - - ✅ ✅
21 ✅ ✅ - -
21-graal ✅ ✅ - -
21-librca - - ✅ ✅
25 ✅ ✅ - -
25-graal ✅ ✅ - -
25-librca - - ✅ ✅

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Summary: Total: 32 | Passed: 32 | Failed: 0


Updated: 2026-10-26 14:37:35 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants