Repository navigation
🍒 Prepare patch: backport 5 PR(s) to release/1.52._ - #906
Conversation
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 7.0.0 to 7.1.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@5fda3b9...6d4fd22) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: 7.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit bca66bf)
…#901) Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-23 to 1.5.7-24. - [Commits](luben/zstd-jni@v1.5.7-23...v1.5.7-24) --- updated-dependencies: - dependency-name: com.github.luben:zstd-jni dependency-version: 1.5.7-24 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit af25ad3)
Bumps the gradle-minor group with 3 updates: [gradle-wrapper](https://github.com/gradle/gradle), [at.yawk.lz4:lz4-java](https://github.com/yawkat/lz4-java) and org.ow2.asm:asm. Updates `gradle-wrapper` from 9.8.1 to 9.8.2 - [Release notes](https://github.com/gradle/gradle/releases) - [Commits](gradle/gradle@v9.8.1...v9.8.2) Updates `at.yawk.lz4:lz4-java` from 1.12.0 to 1.12.1 - [Release notes](https://github.com/yawkat/lz4-java/releases) - [Changelog](https://github.com/yawkat/lz4-java/blob/main/CHANGES.md) - [Commits](yawkat/lz4-java@v1.12.0...v1.12.1) Updates `org.ow2.asm:asm` from 9.11 to 9.11.1 --- updated-dependencies: - dependency-name: gradle-wrapper dependency-version: 9.8.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gradle-minor - dependency-name: at.yawk.lz4:lz4-java dependency-version: 1.12.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gradle-minor - dependency-name: org.ow2.asm:asm dependency-version: 9.11.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gradle-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fe04bd0)
(cherry picked from commit 0ed46a6)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 501dfbc127
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| r"_ZN15SharedLockGuardC\dEP8SpinLock", r"_ZN18ExclusiveLockGuardC\dEP8SpinLock", | ||
| r"_ZN13MutexLockerC\d\w*", | ||
| # stdio | ||
| r"vsnprintf", r"snprintf", r"fprintf", r"printf", r"fflush", r"fopen", |
There was a problem hiding this comment.
Track compiler-lowered stdio sinks
When signal-reachable code uses printf("literal\n") or fprintf(stream, "literal\n"), GCC emits puts or fwrite relocations even at the debug build's -O0; neither symbol matches this sink list, so the new CI check can report clean while the handler still executes async-signal-unsafe stdio. Add these compiler-lowered targets to UNSAFE_SINKS and cover them in the fixture.
AGENTS.md reference: AGENTS.md:L173-L193
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The signal-safety CI gate reports clean when GCC lowers unsafe stdio calls to puts, fputs, or fwrite. This confirms the limitation already acknowledged as deferred in the PR description; the localized suggestion detects those calls.
🤖 Bits Code Review · Commit 501dfbc
| r"_ZN15SharedLockGuardC\dEP8SpinLock", r"_ZN18ExclusiveLockGuardC\dEP8SpinLock", | ||
| r"_ZN13MutexLockerC\d\w*", | ||
| # stdio | ||
| r"vsnprintf", r"snprintf", r"fprintf", r"printf", r"fflush", r"fopen", |
There was a problem hiding this comment.
Recognize compiler-lowered stdio calls as unsafe sinks
GCC lowers literal printf/fprintf calls to puts, fputs, or fwrite even at -O0. These symbols are absent from UNSAFE_SINKS: a focused reproduction containing all three relocations returned zero findings from a recognized signal-handler root. Consequently, the new CI gate can accept async-signal-unsafe stdio. Adding these symbols detected every call and preserved the existing fixture expectations. The PR description acknowledges this deferred limitation.
| r"vsnprintf", r"snprintf", r"fprintf", r"printf", r"fflush", r"fopen", | |
| r"vsnprintf", r"snprintf", r"fprintf", r"printf", r"fflush", r"fopen", | |
| r"puts", r"fputs", r"fwrite", |
React: 👍 useful · 👎 wrong · 😕 unclear · 👀 right, but not acting on it
What each reaction means
- 👍 Useful: correct, and you're fixing it or will.
- 👎 Wrong: the finding is incorrect, for example the bug can't happen or the code was misread.
- 😕 Unclear: you can't tell what it means or why it matters.
- 👀 Right, not acting: correct, but intended, out of scope for this PR, a known risk, or too minor.
🤖 Bits Code Review · Open Bits AI session
CI Test ResultsRun: #40335746794 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-10-26 14:37:35 UTC |
What does this PR do?:
Backports the following PR(s) to
release/1.52._in preparation for the next patch release:Motivation:
Prepares the next patch release from
release/1.52._with the selected main-branch fixes and dependency updates.Additional Notes:
release/1.52._. The author approved opening this PR with one P2 finding deferred: the signal-safety checker can miss compiler-loweredputsandfputscalls. This finding is present in the original Add signal-reachability checker and source quality checks (qualityChecks task) #893 patch.How to test the change?:
For Datadog employees:
credentials of any kind, I've requested a security review (run the
dd:platform-security-reviewskill, or file a request via the PSEC review form).
bewairealso runs automatically on every PR.Unsure? Have a question? Request a review!