fix(security): gate saved-dashboard CRUD on connection ACL (#54) - #58
Open
venkateshsakamuri-lab wants to merge 2 commits into
Open
fix(security): gate saved-dashboard CRUD on connection ACL (#54)#58venkateshsakamuri-lab wants to merge 2 commits into
venkateshsakamuri-lab wants to merge 2 commits into
Conversation
Mirror SavedQueryController: manage on create/update/delete/favorite (persisted connectionId for mutations), read on GETs. Closes #54. Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
venkateshsakamuri-lab
marked this pull request as ready for review
August 15, 2026 14:57
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #54:
SavedDashboardControllercreate/update/delete/favorite (and GET list/by-id/search/folder/favorites) had no connection ACL. Only/share*was checked.Mirrors
SavedQueryController:POST /createassertCanManageConnectionContentconnectionIdPUT/DELETE/favoriteassertCanManageConnectionContentconnectionIdassertCanReadConnectionContent/share*assertCanReadConnectionContent)Updates/deletes authorize against the stored connection so a spoofed body
connectionIdcannot re-home a dashboard onto a connection the caller cannot manage.Test plan
./mvnw test -Dtest=SavedDashboardControllerAccessTest(create denied never persists; update/delete use persisted connection; body spoof ignored; GETs assert read)Closes #54.