Skip to content

Remove hard-coded project names from samples - #767

Merged
lionello merged 1 commit into
mainfrom
fix/644-remove-hardcoded-names
Oct 30, 2026
Merged

lionello merged 1 commit into
mainfrom
fix/644-remove-hardcoded-names

Conversation

@defangdevs

@defangdevs defangdevs commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #644.

The only top-level name: entries in sample compose files were in samples/self-improving (compose.yaml and compose.dev.yaml). Removed both, so the project name comes from the stack or directory instead. No other sample sets one (checked all *compose*.y*ml; Pulumi.yaml names are Pulumi projects, not Compose).

Note: the issue body is empty, so this is my reading of the title. Tell me if it meant something else.

🤖 Generated with Claude Code

https://claude.ai/code/session_01RVYuG3dyo8o95ktRtz5D6K

Samples Checklist

✅ All good!

Summary by CodeRabbit

  • Configuration
    • Development and standard Compose setups no longer specify a fixed project name. Compose now determines the project name using its usual configuration and invocation rules, which may affect how the project is identified when running Compose commands.

@defangdevs
defangdevs temporarily deployed to deploy-changed-samples October 30, 2026 20:10 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 22fa7df5-4ac0-4512-aa9d-6fa18eacee86
Commits

Reviewing files that changed from the base of the PR and between 163d4c2 and 83b4a7a.

Files selected for processing: 2
  • samples/self-improving/compose.dev.yaml
  • samples/self-improving/compose.yaml
Files with no reviewable changes: 2
  • samples/self-improving/compose.yaml
  • samples/self-improving/compose.dev.yaml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Walkthrough

The base and development Compose files no longer set explicit project names. Compose now applies its normal project-naming rules.

Changes: Compose project naming

Layer / File(s) Summary
Remove project name declarations
samples/self-improving/compose.yaml, samples/self-improving/compose.dev.yaml
Both files remove their explicit Compose project name declarations.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: raphaeltm

Merge Risk: Minimal · up to 83b4a

The sample’s documented development and deployment workflows remain supported. No actionable merge-blocking issue was established.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing hard-coded project names from the sample Compose files.
Linked Issues check Passed Issue #644 is open and directly linked. Its title requires removal of hard-coded project names from samples. The whole-PR diff removes name: self-improving from samples/self-improving/compose.yaml…
Out of Scope Changes check Passed The whole-PR diff changes only the two Compose files named in the linked objective. Each change removes one hard-coded Compose project name. No unrelated source, test, or configuration change is prese…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check

Explanation

Issue #644 is open and directly linked. Its title requires removal of hard-coded project names from samples. The whole-PR diff removes name: self-improving from samples/self-improving/compose.yaml and name: self-improving-dev from samples/self-improving/compose.dev.yaml. The PR summary reports that no other sample Compose files contain a top-level name: entry. This change needs no separate automated test because it only removes Compose declarations.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff changes only the two Compose files named in the linked objective. Each change removes one hard-coded Compose project name. No unrelated source, test, or configuration change is present.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lionello
lionello merged commit d9661d8 into main Oct 30, 2026
10 checks passed
@lionello
lionello deleted the fix/644-remove-hardcoded-names branch October 30, 2026 20:24

This branch was previously deployed

1 inactive deployment
deploy-changed-samples — 83b4a7a0 Deployed Oct 30, 2026 by defangdevs via deploy_changed_samples #882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove hard coded project names from samples

2 participants