Repository navigation
Skip result lines with an undeclared report id - #40
Merged
Merged
Conversation
A result line whose id has no output slot for the current frequency raised a bare KeyError and stopped the whole file loading. Such lines are now skipped and logged at debug level. Fixes #39 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
read_bodywrote every result line straight toraw_outputs.outputs[frequency][line_id], so one line with an id not declared for the current frequency raised a bareKeyErrorand stopped the whole file loading. It now skips such lines and logs them at debug level (module loggerdb_eplusout_reader.processing.esofile_reader). No f-strings, so it stays IronPython 2.7-compatible.Tests
New
TestUndeclaredReportIdintests/test_esofile_reader.py:Checked locally
uv run pytest tests -q: 234 passedruff check .,ruff format --check .: cleanpylint db_eplusout_reader: 10.00/10Not run: the IronPython 2.7 path, which isn't installed here.
2 files changed, 41 insertions(+), 2 deletions(-)
🤖 Generated with Claude Code