Repository navigation
Migrate to shared uv + ruff + pylint + pre-commit tooling - #10
Closed
Tokarzewski wants to merge 1 commit into
Closed
Tokarzewski wants to merge 1 commit into
Tokarzewski wants to merge 1 commit into
Conversation
Bring this repo in line with the other db-* repos: - convert pyproject from Poetry to PEP 621 + uv (package = false, since this is a PyInstaller-packaged tool, not an installable library); drop black / flake8 / isort in favour of ruff (check + format) + pylint - add ruff + pylint config; pytest pythonpath = ['src'] so the flat src modules import by bare name - replace .pre-commit-config.yaml with the shared ruff + pylint + pytest hooks; remove .flake8 and poetry.lock, add uv.lock - replace the external reusable-workflow CI with a standard uv-based lint + test matrix workflow (ruff, pylint, pytest on 3.9-3.12) - small fixes: wrap the __main__ block in main(), make the test import consistent, mark the Windows-only ctypes.windll call ruff check + format clean, pylint 10.00/10, 5 tests pass; all pre-commit hooks pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
db-eplustbl-readerin line with the otherdb-*repos: uv + ruff + pylint + pre-commit, replacing the Poetry + black/flake8/isort setup.Changes
[tool.uv] package = false(this is a PyInstaller-packaged tool, not an installable library). Drop black/flake8/isort; dev group isruff,pylint,pre-commit,pytest,pytest-cov,pyinstaller. Add[tool.ruff]+[tool.pylint]config andpytest pythonpath = ["src"]so the flatsrc/modules import by bare name..pre-commit-config.yaml— the sharedruff-imports/ruff-check/ruff-format+ localpylintandpytesthooks (same as db-batch / db-eplusout-reader / db-dsbxml-viewer).run-tests.yml) — replaced the externalvoightp/github-actionsreusable workflows (which assumed Poetry) with a standard uv-based lint + test matrix (ruff + pylint, then pytest on 3.9–3.12)..flake8andpoetry.lock; addeduv.lock.__main__block inmain()(invalid-name), make the test import consistent (db_writer, notsrc.db_writer), and mark the Windows-onlyctypes.windllcall.Verification
Notes
run-build.yml(tag-triggered) still references the external Poetry-based reusable workflow. It doesn't run on PRs; left for a follow-up since the packaging/build flow (PyInstaller) is a separate concern.🤖 Generated with Claude Code