Skip to content

Upgrade filelock to 4.2.10 to clear the Dependabot alerts - #43

Merged
btokarzewskidb merged 2 commits into
mainfrom
claude/security-alerts-4c3393
Nov 16, 2026
Merged

btokarzewskidb merged 2 commits into
mainfrom
claude/security-alerts-4c3393

Conversation

@btokarzewskidb

Copy link
Copy Markdown
Contributor

Clears all 14 open Dependabot alerts. Every one is for filelock, a dev-only transitive dependency (dev extra → pre-commit → virtualenv / python-discovery → filelock).

Alerts

All 14 move from filelock 4.0.3 (locked) to 4.2.10. The fixed version in the table is the one the advisory names.

# Advisory Severity Fixed in
21 GHSA-v4x8-3wr5-3wq8 high 4.2.1
32 GHSA-fq56-3cx3-fjxp moderate 4.2.1
33 GHSA-fj95-fr6c-h845 moderate 4.2.1
34 GHSA-m462-7rxw-wvpg moderate 4.2.1
35 GHSA-j8f7-rjxc-mr56 moderate 4.0.9
36 GHSA-69hj-f68j-2879 moderate 4.2.1
38 GHSA-rfpc-qcw5-3pc4 moderate 4.2.1
39 GHSA-cwqr-hh33-gh44 moderate 4.2.1
40 GHSA-8mx5-7m5m-r77g moderate 4.2.1
41 GHSA-9c4x-gm8v-wgc4 moderate 4.2.1
42 GHSA-6627-m3xw-93mp moderate 4.2.1
29 GHSA-567q-5qvw-pf92 low 4.2.1
30 GHSA-9vhv-jxww-xfm5 low 4.2.1
37 GHSA-9j6q-wvj5-jgjg low 4.2.1

Why pyproject.toml changes

filelock 4.1.1 and later need Python 3.11. A plain uv lock --upgrade-package filelock therefore split the lock: 4.2.10 for Python 3.11+ and 4.1.0 for Python 3.10. 4.1.0 is still covered by every alert. pre-commit is a local hook tool that CI never runs, so the dev extra now installs it only on Python 3.11 and later (pre-commit>=3.6.1; python_version >= '3.11'). After relocking, 4.2.10 is the only filelock entry in uv.lock. Nothing else in the lock changed. The ruff pin is unchanged. Contributors on Python 3.10 who want the git hooks need to install pre-commit themselves.

Other scanners

  • Code scanning: not set up. The API returns "no analysis found".
  • Secret scanning: the API returns 404, so it is either disabled or not visible to this token. No alerts were seen.
  • Workflow actions (actions/checkout@v4, setup-uv@v5, upload/download-artifact@v4, pypa/gh-action-pypi-publish@release/v1): there are no Dependabot alerts for them, and the @v4 tags already resolve past the patched download-artifact 4.1.3. Left unchanged.

Checks (Python 3.12, local)

  • uv sync --extra dev, uv lock --check: OK
  • uv run ruff check dsbxml, uv run ruff format --check dsbxml: pass
  • uv run pylint dsbxml: 10.00/10, exit 0
  • uv run mkdocs build --strict -d site: pass
  • uv run pytest -q: 1 failed, 557 passed, 1 skipped. The failure is test_full_model_round_trip.py::test_model_is_unchanged_after_save_and_reload[shoebox_zone_body.xml] ("root element not found (actual: Body, expected: dsbXML)"). It fails the same way in main's own CI (run for cef1615) and is not caused by this change. The test's samples/*/*.xml glob now also picks up samples/fragments/shoebox_zone_body.xml, which is a <Body> fragment rather than a full model.

🤖 Generated with Claude Code

btokarzewskidb and others added 2 commits November 16, 2026 17:22
filelock is pulled in only by pre-commit (through virtualenv and
python-discovery) in the dev extra. 4.0.3 was locked, which is covered by
14 advisories, all fixed in 4.2.1. filelock 4.1.1 and later need Python
3.11, so on Python 3.10 uv could only lock 4.1.0, which is still
vulnerable. pre-commit is a local hook tool that CI does not use, so the
dev extra now installs it on Python 3.11 and later only. That leaves a
single filelock entry, 4.2.10, in uv.lock.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@btokarzewskidb
btokarzewskidb merged commit 73bca5b into main Nov 16, 2026
6 checks passed
@btokarzewskidb
btokarzewskidb deleted the claude/security-alerts-4c3393 branch November 17, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant