Repository navigation
Upgrade filelock to 4.2.10 to clear the Dependabot alerts - #43
Merged
Merged
Conversation
filelock is pulled in only by pre-commit (through virtualenv and python-discovery) in the dev extra. 4.0.3 was locked, which is covered by 14 advisories, all fixed in 4.2.1. filelock 4.1.1 and later need Python 3.11, so on Python 3.10 uv could only lock 4.1.0, which is still vulnerable. pre-commit is a local hook tool that CI does not use, so the dev extra now installs it on Python 3.11 and later only. That leaves a single filelock entry, 4.2.10, in uv.lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears all 14 open Dependabot alerts. Every one is for
filelock, a dev-only transitive dependency (devextra →pre-commit→virtualenv/python-discovery→filelock).Alerts
All 14 move from
filelock4.0.3 (locked) to 4.2.10. The fixed version in the table is the one the advisory names.Why
pyproject.tomlchangesfilelock4.1.1 and later need Python 3.11. A plainuv lock --upgrade-package filelocktherefore split the lock: 4.2.10 for Python 3.11+ and 4.1.0 for Python 3.10. 4.1.0 is still covered by every alert.pre-commitis a local hook tool that CI never runs, so thedevextra now installs it only on Python 3.11 and later (pre-commit>=3.6.1; python_version >= '3.11'). After relocking, 4.2.10 is the onlyfilelockentry inuv.lock. Nothing else in the lock changed. Theruffpin is unchanged. Contributors on Python 3.10 who want the git hooks need to installpre-committhemselves.Other scanners
actions/checkout@v4,setup-uv@v5,upload/download-artifact@v4,pypa/gh-action-pypi-publish@release/v1): there are no Dependabot alerts for them, and the@v4tags already resolve past the patcheddownload-artifact4.1.3. Left unchanged.Checks (Python 3.12, local)
uv sync --extra dev,uv lock --check: OKuv run ruff check dsbxml,uv run ruff format --check dsbxml: passuv run pylint dsbxml: 10.00/10, exit 0uv run mkdocs build --strict -d site: passuv run pytest -q: 1 failed, 557 passed, 1 skipped. The failure istest_full_model_round_trip.py::test_model_is_unchanged_after_save_and_reload[shoebox_zone_body.xml]("root element not found (actual: Body, expected: dsbXML)"). It fails the same way in main's own CI (run forcef1615) and is not caused by this change. The test'ssamples/*/*.xmlglob now also picks upsamples/fragments/shoebox_zone_body.xml, which is a<Body>fragment rather than a full model.🤖 Generated with Claude Code