fix(mcp): emit trace evidence columns in header order - #1703
Conversation
json + include_evidence + data_flow labeled args as strategy because bfs_to_tree_json declared strategy,confidence before args but emitted args first. Tree flat_trace (risk_labels or data_flow) also dropped include_evidence by calling bfs_to_toon_table without the flag. Fixes DeusData#1542 Signed-off-by: rudi193-cmd <rudi193@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Thank you for the focused follow-up to #1542. This is the right review shape: one output-contract defect, two production branches, and tests that bind column identity rather than merely row width. The initial patch scan found no new dependency, execution, network, or configuration surface. It is labeled high priority because silently mislabeling trace evidence is a correctness bug. The review queue is full, but this contribution is now routed as a compact bug fix. |
What does this PR do?
The original #1542 json omission landed in v0.10.3. Two leftovers remained on
main:bfs_to_tree_jsondeclaredstrategy, confidencebeforeargsbut emittedargsfirst, sojson + include_evidence + data_flowmislabeled columns (len(cols)==len(row)still held).flat_trace(risk_labelsordata_flow) calledbfs_to_toon_tablewithoutinclude_evidence, so evidence was a silent no-op on that branch.This PR emits cells in header order and forwards the flag into the flat table. Tests assert column identity, not just count.
Not folding in #1597 budget signalling.
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
scripts/test.sh --suites mcp)make -f Makefile.cbm lint-ci)Fixes #1542
Made with Cursor