Skip to content

chore: pin .nvmrc to Node major version - #1015

Merged
jonathannorris merged 1 commit into
mainfrom
chore/nvmrc-major-version
Nov 3, 2026
Merged

jonathannorris merged 1 commit into
mainfrom
chore/nvmrc-major-version

Conversation

@jonathannorris

Copy link
Copy Markdown
Member

Summary

  • Change .nvmrc from 24.19 to 24 so nvm resolves the latest Node 24 patch release instead of an old minor that is missing security fixes (e.g. CVE-2026-111497).

Copilot AI balanced review requested due to automatic review settings November 3, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the .nvmrc update to select Node 24.

No open issues 🎉

What changed in this PR

Updates the project’s Node.js version selection so nvm can resolve newer releases within Node 24.

Changes:

  • Replaces 24.19 with the major-only version 24 in .nvmrc.
File Description
.nvmrc Allows nvm to select the latest available Node 24 release during installation.

Review effort: Balanced

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying devcycle-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f7fd80f
Status: ✅  Deploy successful!
Preview URL: https://41df0df3.devcycle-docs.pages.dev
Branch Preview URL: https://chore-nvmrc-major-version.devcycle-docs.pages.dev

View logs

@jonathannorris
jonathannorris merged commit d17f918 into main Nov 3, 2026
6 checks passed
@jonathannorris
jonathannorris deleted the chore/nvmrc-major-version branch November 3, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants