Repository navigation
Inline V8 flags filter dependency - #8571
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new filter test is not run by any automated test command, leaving CI unable to catch regressions in the inlined filter.
1 open issue
What changed in this PR
This PR moves the V8 flag filter into TestCafe’s CLI code, removing the external npm dependency.
Changes:
- Inlines the filter implementation with its MIT license notice.
- Switches the CLI wrapper to the local module and removes the dependency.
- Adds a regression test for V8 flag and forced-argument forwarding.
| File | Description |
|---|---|
test/node/v8-flags-filter-test.js |
Adds a subprocess-based flag-forwarding test. |
package.json |
Removes the external filter dependency. |
package-lock.json |
Removes the dependency’s lockfile entries. |
bin/v8-flags-filter.js |
Adds the local flag filter and child-process handling. |
bin/testcafe-with-v8-flag-filter.js |
Imports the local filter implementation. |
Review effort: Balanced
Bayheck
approved these changes
Nov 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Code from https://github.com/DevExpress/bin-v8-flags-filter repository inlined here to get rid of @devexpress/bin-v8-flags-filter npm dependency