Skip to content

Inline V8 flags filter dependency - #8571

Merged
aleks-pro merged 3 commits into
DevExpress:masterfrom
aleks-pro:master
Nov 10, 2026
Merged

aleks-pro merged 3 commits into
DevExpress:masterfrom
aleks-pro:master

Conversation

@aleks-pro

@aleks-pro aleks-pro commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Code from https://github.com/DevExpress/bin-v8-flags-filter repository inlined here to get rid of @devexpress/bin-v8-flags-filter npm dependency

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new filter test is not run by any automated test command, leaving CI unable to catch regressions in the inlined filter.

1 open issue
What changed in this PR

This PR moves the V8 flag filter into TestCafe’s CLI code, removing the external npm dependency.

Changes:

  • Inlines the filter implementation with its MIT license notice.
  • Switches the CLI wrapper to the local module and removes the dependency.
  • Adds a regression test for V8 flag and forced-argument forwarding.
File Description
test/​node/​v8-flags-filter-test.js Adds a subprocess-based flag-forwarding test.
package.json Removes the external filter dependency.
package-lock.json Removes the dependency’s lockfile entries.
bin/​v8-flags-filter.js Adds the local flag filter and child-process handling.
bin/​testcafe-with-v8-flag-filter.js Imports the local filter implementation.

Review effort: Balanced

Comment thread test/server/v8-flags-filter-test.js Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The regression test uses node:test instead of Mocha, leaving it outside the configured suite’s test and failure counts, test selection, and timeout handling.

1 open issue

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the change to inline the V8 flags filter and remove its external dependency.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@aleks-pro
aleks-pro merged commit 9aa493c into DevExpress:master Nov 10, 2026
20 checks passed

This branch was successfully deployed

1 active deployment
CI — 688c6673 Deployed Nov 9, 2026 by aleks-pro via request-deploy #5078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants