Repository navigation
build(deps): pin spec-kit at d8a8271, which adds the clients' own error codes - #96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All six spec-kit pins move from 4ef22b7 to d8a8271, the dev merge of DevelopmentFinanceObservatory/spec-kit#16. That commit adds six client error codes (
key_invalid,credentials_file_unreadable,header_invalid,insecure_transport,base_url_invalid,response_too_large) to the client contract'sclient-codes.json. Nothing the app serves changes: the served document and scenarios are those recorded at 035d29c. The SDK's contract job requires its contract pin to follow this one, so the SDK can raise the new codes once this lands.Testing:
tests/contractandtests/platformgive 987 passed against the new pin.