Skip to content

Assumption echoes discard asked and erase name corrections on resubmission #38

Open

Description

@jm-rivera

tools/validate_client_contract.py:read_assumption keeps kind, binding_ref, text and refs, but discards asked, which the OpenAPI snapshot released in #35 adds to name-correction assumptions. Both reading_echo and resubmit_entry use this reader.

The pinned API’s _held_name_corrections drops an echoed correction without asked. Choosing another part’s reading therefore silently removes an existing correction warning.

This reproduces the lost field:

from tools.validate_client_contract import read_assumption

item = {
    "kind": "name_corrected",
    "binding_ref": "where:",
    "text": '"Germny" read as Germany',
    "refs": ["country/DEU"],
    "asked": "Germny",
}
assert read_assumption(item)["asked"] == "Germny"  # raises KeyError

Done when

  • Assumption echoes preserve a valid asked value.
  • A scenario covers a name correction surviving a choice or resubmission.
  • The contract documentation describes how clients read and echo asked.

Activity

  1. added
    bugSomething isn't working
    P2Minor: looks wrong or confuses people, but still usable. Schedule it.
    on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Minor: looks wrong or confuses people, but still usable. Schedule it.bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions