Skip to content

test(dgw): add DVLS 2026.3 JREC fixtures - #1957

Open
Krista House (kristahouse) wants to merge 2 commits into
masterfrom
kristahouse-didactic-enigma
Open

test(dgw): add DVLS 2026.3 JREC fixtures#1957
Krista House (kristahouse) wants to merge 2 commits into
masterfrom
kristahouse-didactic-enigma

Conversation

@kristahouse

@kristahouse Krista House (kristahouse) commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Follow-up from review of PR #1857 (DGW-403).

Add versioned JREC compatibility coverage in dvls_compatibility tests with deterministic push/pull fixtures and property-based claim shape validation, including optional jet_reuse.

Issue: DGW-407

@kristahouse
test(dgw): add DVLS 2026.3 JREC fixtures
3e84328 
Add versioned JREC compatibility coverage in dvls_compatibility tests
with deterministic push/pull fixtures and property-based claim shape
validation, including optional jet_reuse.

Issue: DGW-407
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 27, 2026 17:09
@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copilot AI reviewed Aug 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds DVLS 2026.3 JREC compatibility coverage to Gateway token validation.

Changes:

  • Models push, pull, and optional reuse claims.
  • Adds property-based and deterministic validation cases.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread devolutions-gateway/tests/dvls_compatibility.rs Outdated
@kristahouse
test(dgw): cover jrec disallow-reuse boundary
312d868 
Address PR feedback by covering the explicit DVLS JREC shape
with jet_reuse set to 0.

Update the generator to include 0..=900 and add a fixed
push_disallow_reuse sample fixture.

Issue: DGW-407
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kristahouse
Krista House (kristahouse) requested a balanced review from Copilot August 27, 2026 17:59
Copilot AI reviewed Aug 27, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@CBenoit Benoît Cortier (CBenoit) Awaiting requested review from CBenoit

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kristahouse