Repository navigation
Conversation
… tuning files, and every device's name Three things the owner's first report could not say: - Whether db and KEK still hold Microsoft's certificates after work in the firmware's key settings. The image has no efi-readvar, sbctl or mokutil, and booting with Secure Boot on shows only that Kryptik's own is there. Every Microsoft CA names Microsoft in its subject, so a line each says yes or no. - Which tuning files a Cirrus CS35L54, CS35L56 or CS35L57 asks for. They are named by the codec's subsystem ID, and cs35l56-hda asks without logging a name, so nothing in the report gave firmware.list its line. It goes on a line of its own, amplifier-tuning, as check-hardware.sh reads every field after an amplifier's third as a driver. - The names of PCI devices. pci_named read hwdata's pci.ids, which image-excludes.txt leaves out, so on a real machine every line carried IDs only. Without it the names come from udev's hwdb, which the image builds, asked by each device's modalias, in the same form. Checks: tools/tests/hwreport.sh gains a db naming Microsoft and a KEK that does not, a CS35L54 machine whose pattern carries its codec's subsystem while its listing still reads "amplifiers CSC3554", no pattern for a CS35L41, and a run with pci.ids away and a stand-in hwdb. The VM run wants the xHCI controller's names from the medium's own hwdb.
The audit's tpm-report:9: the report's ACPI sensor list held only the IDs Intel's ipu-bridge knows, so the OmniVision sensor amdgpu's ISP looks for (OMNI5C10, in HP's ZBook Ultra G1a) showed as an unnamed device with no driver. OMNI* joins the sensors; check-hardware.sh lists it as it does the others.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit's tpm-report:3, :4 and :7: three things the owner's first hardware report could not say.
firmware()):db holds microsoft's certificates: yes|no|-, and the same for KEK.audio()): for a CSC3554, CSC3556 or CSC3557, a lineamplifier-tuning CSC3554:00 cirrus/cs35l54-*-dsp1-misc-<codec subsystem>*.firmware_request_nowarn, logging no name, so nothing else in the report gives firmware.list its line.check-hardware.shreads every field after anamplifierline's third as a driver.pci_named()): it read/usr/share/hwdata/pci.ids, whichimage-excludes.txtleaves out, so every line on a real machine carried IDs only.pci_hwdb()asks udev's hwdb (/usr/lib/udev/hwdb.bin, built byeudev.sh) by each device's modalias.| class | vendor modelform.Checks:
tools/tests/hwreport.sh:check-hardware.shstill lists "amplifiers CSC3554, not driven";udevadmthat knows only the radio. The radio is named, and a device it doesn't know has no names.-), which CI's Linux run doesn't have.tools/image/hwreport-test.shwants the xHCI controller's line to carry names from the medium's own hwdb.The report runs only when asked, on the medium. Base: zbook-batch-4 (#656). Tectonix: 5808 → 5808, no violations.