Repository navigation
fix(security): the certificate check refuses TLS below 1.2 (CodeQL py/insecure-protocol) - #25
Merged
Merged
Conversation
…/insecure-protocol) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CodeQL #2 (
py/insecure-protocol, high,scripts/security.py:353). Task: Digitizers/digitizer-tasks#195.connect_public_tls()(the site audit's certificate-expiry check) wrapped its socket with a baressl.create_default_context(). On Python builds whose OpenSSL still allows TLS 1.0/1.1 that context negotiates them: on this machine itsminimum_versionisTLSv1. It now setsminimum_version = TLSv1_2.Test first:
DnsPinningTest.test_the_certificate_check_refuses_tls_below_1_2captures the context passed towrap_socket. It failed before the fix (TLSVersion.TLSv1 not >= TLSv1_2), passes after. Suite: 130 passed;npm testgreen.🤖 Generated with Claude Code