Repository navigation
fix: Daisyworld and MonoLake as in TerraME; every model bit-identical… - #19
Merged
Merged
Conversation
… to TerraME runs Compared with TerraME 2.0.1 runs of the sysdyn package (terrame-goldens v0.1.0): - Daisyworld: the planet albedo for the black daisies is computed again after the white area is updated, as in the Lua model. New attributes temp_near_white and temp_near_black. - MonoLake: lake surface and elevation through TerraME's sci.Spline (a Catmull-Rom curve sampled at 1000 points per segment, read linearly; new models._spline.Spline) instead of scipy's CubicSpline, an undeclared dependency. As in TerraME, a volume outside the curve raises an error. - PredatorPrey, RoomTemperature, SIR and MonoLake: arithmetic in TerraME's order. All 16 deterministic cases now give the same doubles as TerraME at every step. tests/test_goldens.py (marker golden) checks it bit for bit from a copy of the goldens in tests/goldens (SHA-256 provenance and the script that copies them), and RandomWalk by distribution. The strict xfails of Daisyworld and MonoLake are removed. The Mono Lake notebook uses the new Spline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WHohDPhCtXJvVZ7jTGwK8e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compared with TerraME 2.0.1 runs of the sysdyn package (terrame-goldens v0.1.0):
All 16 deterministic cases now give the same doubles as TerraME at every step. tests/test_goldens.py (marker golden) checks it bit for bit from a copy of the goldens in tests/goldens (SHA-256 provenance and the script that copies them), and RandomWalk by distribution. The strict xfails of Daisyworld and MonoLake are removed. The Mono Lake notebook uses the new Spline.