ENG-2266 Make advanced node search popovers keyboard controllable

[trangdoan982]

Reviewer brief

• Result: All three advanced node search popovers (type filter, sort, display options) are keyboard controllable through the shared SearchDropdown. Opening by keyboard focuses the selected or first item. ArrowUp/ArrowDown move through the items and wrap. Tab and Shift+Tab only close the popover and return focus to its trigger. Escape and outside clicks behave as before (light dismiss). Div items get a keyboard-only focus ring. This folds in ENG-2263's Tab-away close.
• Review focus:
  • A pointer open focuses the panel itself rather than an item. Chromium carries :focus-visible over from the focused search input, so focusing an item would ring a mouse open.
  • "Clear filter" moves focus back to the panel when it held focus, because it unmounts on click.
  • On the accent-filled selected row, the inset ring uses --background-modifier-border-focus. It's visible in the default theme but subtle.
• Risk or follow-up:
  • The filter's "Only" buttons are now mouse-only.
  • After a keyboard open, a mouse click on another sort row leaves focus and the ring on the previous row.
  • Home/End, Left/Right and type-to-jump are not included.
  • Supersedes draft PRs ENG-2263 Fix advanced node search dropdown menus don't close on Tab-away and can close prematurely on click #1446 (ENG-2263) and ENG-2266 Make the advanced node search sort menu keyboard navigable #1451 (ENG-2266).

Verification

• pnpm ci:validate passes on the PR head.
• I verified the behaviour live in Obsidian over CDP. All 14 scenarios passed:

Scenario	Result
Sort: keyboard open, ArrowDown ×7, ArrowUp	Relevance → … → Author → Asc → Desc → Relevance; Up from Relevance → Desc; ring visible; result highlight unchanged
Sort: Tab / Shift+Tab	Closes; focus on sort trigger; sort unchanged
Mouse open	Panel focused, no ring; first ArrowDown rings the first row
Click another trigger	Sort closes and filter opens in one click
Outside click on a result	Popover closes; the click still highlights the result
Escape	Closes; modal stays; focus in search input
Type filter arrows	One stop per type row, wraps, never lands on "Only"
Filter label / colour dot click	Toggles every time; panel stays open
Clear filter by keyboard	Filter cleared; focus stays in panel; arrows keep working
"Only" on keyboard focus	Stays hidden (opacity 0)
Display options	Focus on toggle with ring; Enter toggles; stays open
Ring on selected sort row, ring in dark theme	Inset ring present

Loom video

https://www.loom.com/share/e9057b831841450ca6553fbb47f4d62b

Scope check

• Ran $scope-check against ENG-2266 and the final diff.
• Scope beyond Done When:
  • Focus-on-open and arrow navigation are in the shared SearchDropdown, so the type filter and display options popovers get them too.
  • Tab and Shift+Tab only close a popover and return focus to its trigger. This is ENG-2263's Tab-away close.
  • The display toggle gets the focus ring.
  • The filter's "Only" button is now mouse-only.
  • Focus stays in the panel after "Clear filter" is pressed by keyboard.
• Required now: the requester asked for one consistent keyboard model across the search popovers, with ENG-2263 folded in. Doing it per menu would duplicate the logic across the shared component's callers.
• Decision: ENG-2266 scope update comment. ENG-2263 is canceled as absorbed.

Standards check

• Ran $dg-pr-adherence-check against the final diff and PR metadata.

Local delegated full review

• Ran a comprehensive review of the entire final diff in a subagent with a fresh context. Use $dg-delegated-full-review when no other full-review workflow is available.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
discourse-graph	Skipped		Oct 17, 2026 2:59pm UTC

[linear-code]

ENG-2266

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[devin-ai-integration]

Devin Review found 1 potential issue.

1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)