Repository navigation
fix(web): return the audit log pagination to the first page when the sort changes - #1918
Merged
joshunrau merged 1 commit intoNov 19, 2026
Conversation
…sort changes Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
joshunrau
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1662
Sorting from a later page fetched page 1 but left the table's own page index where it was, so Next skipped a page. As suggested in the triage comment,
SortableHeadernow takes the table and callstable.firstPage()after toggling the sort, every audit log column passes it, andonSortingChangeno longer sets the page itself. The instrument repository sync log table has the same pattern since #1869 and could pass the table the same way.