Skip to content

fix(web): return the audit log pagination to the first page when the sort changes - #1918

Merged
joshunrau merged 1 commit into
DouglasNeuroInformatics:mainfrom
SAY-5:fix/1662-audit-logs-sort-first-page
Nov 19, 2026
Merged

joshunrau merged 1 commit into
DouglasNeuroInformatics:mainfrom
SAY-5:fix/1662-audit-logs-sort-first-page

Conversation

@SAY-5

@SAY-5 SAY-5 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Closes #1662

Sorting from a later page fetched page 1 but left the table's own page index where it was, so Next skipped a page. As suggested in the triage comment, SortableHeader now takes the table and calls table.firstPage() after toggling the sort, every audit log column passes it, and onSortingChange no longer sets the page itself. The instrument repository sync log table has the same pattern since #1869 and could pass the table the same way.

…sort changes

Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
@SAY-5
SAY-5 requested a review from joshunrau as a code owner November 13, 2026 11:26
@github-actions github-actions Bot added the Status: Waiting on Review Automated: unreviewed, pushed since the last review, or review re-requested label Nov 13, 2026
@joshunrau
joshunrau merged commit 2a69733 into DouglasNeuroInformatics:main Nov 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Waiting on Review Automated: unreviewed, pushed since the last review, or review re-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-sorting the audit logs from a later page shows page 1 while the pagination stays on the old page, so Next skips pages

2 participants