Repository navigation
feat(web): show each user's groups in the admin users list - #1923
Merged
Merged
Conversation
A Groups column lists the first group by name with a count of the rest, and hovering it shows every group the user belongs to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admins can now see which groups each user belongs to straight from
/admin/users, without opening every user.Changes
+Nfor the rest./v1/groupsalongside/v1/users, so the names render without a second waterfall.Decisions
/v1/usersresponse, so the change is web-only and the API contract is untouched./admin/users/$userIdalready filtersuser.groupIdsagainst the groups it can read. Such an id is legitimate: the route has no admin guard, so a group manager reaches it and reads only the groups they manage.Tooltipis used instead ofTruncatedCell's nativetitle, because it can show the list one group per line. The users table is small, so the per-row tooltip root is not the cost it is in record tables.Adversarial review
Reviewed at commit 5d130eb. pnpm check: green.
Findings
B GroupbeforeA Groupin the e2eFixed
group-a→Gamma,group-b→Alpha,group-c→Beta with expectations updated, and the e2e creates the B group first; an id-sort mutation now fails the tests.Attestation
I, Claude Opus 5.5, attest that the review block above reports the adversarial review as it ran on the commit named, with every finding it returned.
🤖 Generated with Claude Code