fix(maestro): repair recent existing test flows - #6172
Open
EdgeClaws wants to merge 16 commits into
Open
Conversation
EdgeClaws
force-pushed
the
qa/maestro-recent-test-fixes
branch
from
August 21, 2026 22:17
b4a24cf to
f995b79
Compare
This was referenced Aug 21, 2026
EdgeClaws
force-pushed
the
qa/maestro-recent-test-fixes
branch
16 times, most recently
from
August 31, 2026 18:45
4806f40 to
9a1e3c7
Compare
EdgeClaws
force-pushed
the
qa/maestro-recent-test-fixes
branch
from
September 1, 2026 00:07
3b87afa to
b6fdfcd
Compare
EdgeClaws
marked this pull request as ready for review
September 1, 2026 00:10
2 tasks
EdgeClaws
force-pushed
the
qa/maestro-recent-test-fixes
branch
3 times, most recently
from
September 1, 2026 04:20
0aea92f to
2b2bec8
Compare
The tag was C000029 but the flow is C000029a; a C000029a tag-filtered run silently skipped it. Match the tag to the test ID. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JP0P
force-pushed
the
qa/maestro-recent-test-fixes
branch
from
September 1, 2026 23:16
2b2bec8 to
533b1b6
Compare
peachbits
requested changes
Sep 1, 2026
| <Pressable style={styles.row} onPress={handleToggle}> | ||
| <Pressable | ||
| style={styles.row} | ||
| testID={`manageTokensRow.${token.currencyCode}`} |
Contributor
There was a problem hiding this comment.
use a more unique string like concatenating the currency code and displayname
Contributor
There was a problem hiding this comment.
We did consider this but didn't want to complicate it too much. Making that exact change now.
EdgeClaws
force-pushed
the
qa/maestro-recent-test-fixes
branch
from
September 2, 2026 00:59
533b1b6 to
e01e778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QA owns the Maestro YAML in this PR. Developer review is limited to the three TypeScript files and their matching changelog entries below.
Review scope
Four
testIDadditions:WalletSettingsModal.tsx—walletSettingsNameInput,walletSettingsDoneButtonCreateWalletEditNameScene.tsx—splitWalletConfirmButtonManageTokensRow.tsx—manageTokensRow.<currencyCode>CHANGELOG.md— threechanged:entries covering those hooksThese expose existing controls to Maestro. There are no visible UI, behavior, or business-logic changes.
Dependency context
developnow supplies publishededge-login-ui-rn@^3.37.2. The temporary GitHub pin used for build validation is gone; 3.37.2 contains the exact spinner-ID source validated in matched Android/iOS build26083001.QA verified all four app hooks on iPhone 17 and iPhone 17e. Asana handoff