Skip to content

Explain an empty Manage Tokens search result - #6189

Open
j0ntz wants to merge 1 commit into
developfrom
jon/manage-tokens-qa-followup
Open

Explain an empty Manage Tokens search result#6189
j0ntz wants to merge 1 commit into
developfrom
jon/manage-tokens-qa-followup

Conversation

@j0ntz

@j0ntz j0ntz commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Manage Tokens now says when a search matches nothing.

Searching Manage Tokens for a contract address the wallet's token list does not carry rendered a bare scene: no rows, no message, and the "Add Custom" button hidden behind the keyboard. That frame is pixel-identical to a search that is not matching at all, so nobody can tell "this token is not in the list" from "the search is broken".

That ambiguity is what this PR's task is about. QA filed 1217587221308437 against the Manage Tokens contract-address search, that search was fixed in EdgeApp/edge-react-gui#6170, and a later QA pass attached another blank-scene screenshot. This run reproduced the QA steps on current develop and the search works: the full MOG contract address 0xaaeE1A9723aaDB7afA2810263653A34bA2C21C7a returns the Mog row, and so does UNI's 0x1f9840a85d5af5bf1d1762f925bdaddc4201f984. What the blank frame cannot show is which of the two causes produced it.

MOG makes the gap easy to hit. It is not a built-in token: it is absent from edge-currency-accountbased's compiled Ethereum list and from the info-server token payload, so it only exists in an account after someone adds it through "Add Custom". On an account that never did, an address search for it correctly returns nothing, and says nothing.

The fix renders a centered message in the list's empty slot while a search is active. A search that matches nothing now says so, and points at the control that adds the token.

Asana: https://app.asana.com/0/1215088146871429/1218117826000799

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@j0ntz

j0ntz commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

📸 Test evidence

mog full address finds mog

mog full address finds mog

unknown address says no match

unknown address says no match

Captured by the agent's in-app test run (build-and-test).

Searching Manage Tokens for a contract address the wallet's token list
does not carry rendered a bare scene: no rows, no message, and the
"Add Custom" button hidden behind the keyboard. That is pixel-identical
to a search that is not matching at all, which is how a QA pass read a
working contract-address search as a failure.

Render a centered message in the list's empty slot while a search is
active. A search that matches nothing now says so.
@j0ntz
j0ntz marked this pull request as ready for review September 2, 2026 23:56
@j0ntz
j0ntz force-pushed the jon/manage-tokens-qa-followup branch from b20e560 to f4c0d2d Compare September 2, 2026 23:56
@cursor

cursor Bot commented Sep 2, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant