Rename "Collaborators" "Maintainers" for learning paths & topics. - #1375
Open
fbacall wants to merge 1 commit into
Open
Rename "Collaborators" "Maintainers" for learning paths & topics. #1375fbacall wants to merge 1 commit into
fbacall wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
User-facing i18n strings introduced in en.yml contain grammar/spacing errors that should be fixed before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Renames the “Collaborators” UI label to “Maintainers” specifically for Learning Paths and Topics, and updates the collaborators modal to use i18n-backed strings so the wording can vary by resource type.
Changes:
- Add model-specific i18n attribute labels so
collaboratorsrenders as “Maintainers” forLearningPathandLearningPathTopic. - Update Learning Path / Topic show sidebars and the shared collaborators modal button/header to use those i18n labels.
- Add controller tests asserting the UI shows “Maintainers” for Learning Paths and Topics.
File summaries
| File | Description |
|---|---|
| test/controllers/learning_paths_controller_test.rb | Adds assertions that the collaborators UI is labeled “Maintainers” on learning path show. |
| test/controllers/learning_path_topics_controller_test.rb | Adds assertions that the collaborators UI is labeled “Maintainers” on topic show. |
| config/locales/en.yml | Adds attribute label overrides for learning paths/topics and new i18n strings for the collaborators modal. |
| app/views/learning_paths/show.html.erb | Switches sidebar heading to use LearningPath attribute translation for collaborators/maintainers label. |
| app/views/learning_path_topics/show.html.erb | Switches sidebar heading to use LearningPathTopic attribute translation for collaborators/maintainers label. |
| app/views/collaborations/_collaborators_button.html.erb | Makes the collaborators button/modal label and helper text driven by i18n + model attribute name. |
Review details
Suppressed comments (1)
config/locales/en.yml:1206
- The collaborators info string is missing a space in “%{resource_type}owner”, which will render as e.g. “Learning pathowner”.
the %{resource_type}owner can add and remove %{attribute}.
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1199
to
+1201
| Groups is a feature which for now is used only to manage access of private spaces. | ||
| A user being part of a group has access to every private space which requires the group. | ||
| Each group has multiple owners. A owner can add and remove people to the group. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
#1350
Checklist