Repository navigation
Accept dsh 0.2 prereleases in the peer ranges - #44
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
>=0.1.5-0(from #28) looks open-ended, but npm and pnpm check peers withoutincludePrerelease, and then a prerelease only satisfies a comparator on its ownmajor.minor.patch. So the range refuses every dsh 0.2 prerelease the plugin already runs on:>=0.1.5-00.2.0-rc.20.2.1-rc.2next0.2.1-alpha.5alphaCI's
dsh-compatibility (next)and(alpha)jobs already pass against those lines; only the declared range is wrong. It also makes dshfind's Desktop install check fail onruntime-range:*once its Desktop version constant catches up.>=0.1.5-0 || >=0.2.0-0 || >=0.2.1-0: one branch per line, still no upper bound. A later prerelease line (0.2.2-*,0.3.0-*) needs its own branch.^4.0.5-0for the4.0.5-alpha.*the dsh alpha line pins.test/peer-ranges.test.jschecks the ranges with strict semver against each line. On the old ranges two of its three tests fail.npm users get this from the next release; this PR does not bump the version.
🤖 Generated with Claude Code
Note
Low Risk
Metadata-only peer range and test changes; no runtime plugin logic is modified.
Overview
Fixes declared peer dependency ranges so npm/pnpm no longer reject DSH 0.2.x prereleases the plugin already supports. Under default semver (no
includePrerelease),>=0.1.5-0does not match0.2.0-rc.2and similar lines.DSH peers (
dsh-llm,dsh-skill,dsh-tools) are now>=0.1.5-0 || >=0.2.0-0 || >=0.2.1-0—one lower-bound branch per supported release line, still without an upper cap. Cordis adds^4.0.5-0alongside the existing^4.0.1-rc.1for alpha-track cordis pins.Adds
semveras a dev dependency andtest/peer-ranges.test.jsto assert accepted/rejected versions againstpackage.jsonpeers (including older-than-0.1.5 rejections).Reviewed by Cursor Bugbot for commit 37f66e7. Bugbot is set up for automated code reviews on this repo. Configure here.