Repository navigation
[No QA] Order CODEOWNERS so the workflows rule takes precedence - #891
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
melvin-bot
Bot
requested review from
marcochavezf
and removed request for
a team
November 10, 2026 21:04
Julesssss
approved these changes
Nov 11, 2026
aldo-expensify
approved these changes
Nov 11, 2026
Contributor
|
Contributor
|
@NicolasBonet looks like this was merged without a test passing. These checks had not passed on b83d06b when it was merged:
Please add a note explaining why this was done and remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
In CODEOWNERS the last matching pattern wins. Because
* @Expensify/pullerbearcame after the.github/workflows/rule, it also matched workflow files and the dedicated workflow owners were never requested.This puts the
*rule first so the.github/workflows/rule applies to workflow changes, which is the same ordering App uses. expensify-common has the same file and gets the same $ Expensify/expensify-common#971Related Issues
https://github.com/Expensify/Expensify/issues/702575
Linked E/App PR
N/A. This only changes
.github/CODEOWNERS, so nothing ships to npm and App is unaffected.Automated Tests
None needed. No code changes.
Manual Tests
.github/workflows/.Author Checklist
### Related Issuessection above### Linked E/App PRsection above, and verified this change against it (E/App CI passed and manual testing completed)TestssectiontoggleReportand notonIconClick)myBool && <MyComponent />.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Avataris modified, I verified thatAvataris working as expected in all cases)mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A, no app changes.
Android: mWeb Chrome
N/A, no app changes.
iOS: Native
N/A, no app changes.
iOS: mWeb Safari
N/A, no app changes.
MacOS: Chrome / Safari
N/A, no app changes.