Gate ELRS modules below the 3.5.4 minimum - #22
Open
Itay-Sharoni wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11
A module older than 3.5.4 predates the spec-compliant folders of
ExpressLRS/ExpressLRS#3123, which the parameter loader is built on. The
tool cannot browse such a module - as reported, it just sits at the
loading screen.
The DEVICE_INFO answer that discovery already gets carries the firmware
version, so gate there: when an ELRS TX reports something below 3.5.4,
show the existing unsupported-firmware screen with the actual version
("ELRS 3.4.2 detected. Requires 3.5.4 or later.") instead of starting
to load. Same pattern as the 1.x detection.
The simulator's fake devices advertised 3.5.0, which the gate would now
refuse - they report 4.1.0, and a new "old_firmware" scenario reports
3.4.2 to exercise the screen.
Checked in the CRSFSimulator: "old_firmware" shows the message, "normal"
loads as before. I could not test against a real 3.4.2 module.