feat(action): add fail-closed model policy mode - #134
Open
l30t wants to merge 3 commits into
Open
Conversation
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Contributor
|
Droid finished @l30t's task —— View job Droid review summary Solid wiring change overall, with tests covering the new input across action variants. The main gaps are around fail-closed ergonomics: fail mode still retries deterministic model failures, and invalid fallback configuration is only validated on the disallowed-model path. |
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_policy_fallbackinput to the main, review, security, and base actionsfailmode so policy-blocked or invalid requested models never retry with the organization's default modelorganization-defaultas the existing default behaviorMotivation
This is the upstream prerequisite for the CLI-2122 Droid Review migration. Factory's review workflows need to pin review and security models without silently changing models when organization policy or the CLI rejects those pins.
Testing
bun test(595 passed)bun run typecheckbun run format:checkactionlint .github/workflows/*.yml