feat: add addi-decisioning plugin with validating-decisioning-e2e-tests skill

[mcsanchez-addi]

What

Adds a new plugin addi-decisioning that ships the validating-decisioning-e2e-tests skill.

Given a Notion page URL that lists Decisioning E2E test scenarios (rows with application-id, expected Offers result, and allyName), the skill:

1. Extracts every row from the Notion page via the Notion MCP.
2. Queries originations_v3_sas.legacy_loan_application on the staging Aurora cluster through a local port-forward (localhost:15432) using AWS RDS IAM auth.
3. Evaluates each case against a fixed rulebook:
   • APR bands: STANDARD_BELOW_USURY (< 0.3), LBL_BAND (> 0.4), ZERO (= 0/null).
   • Guarantee: FGA, FGA 0.00 (rate=0/null), NONE.
   • Learning population: LP, non-LP.
   • IDV tokens (HARD_IDV, SOFT_IDV, PHONE_VERIFICATION, EMAIL_VERIFICATION, HIGH_SCRUTINY, VALIDATION_CALL) — allyName presence only.
   • Rejections: REJECTED_BY_HARDCUTS / REJECTED_BY_POLICY (status must be NULL or REJECTED).
   • allyName substring check on the raw JSONB.
4. Prints a per-row Case | Application ID | Expected | Status | Verdict table plus a failure breakdown.
5. On explicit user confirmation, writes the ✅ / ❌ verdict back into the Notion Result column via notion-update-page.

Why

Every Decisioning deploy today requires manually clicking through ~12 Notion rows per phase and running JSONB lookups by hand. This skill turns the whole batch into a single command, standardizes the ruleset (APR bands, FGA vs NONE guarantee, LP/non-LP, IDV tokens, rejection statuses), and produces an auditable verdict per row.

Layout

plugins/addi-decisioning/
├── .factory-plugin/plugin.json
├── README.md
└── skills/
    └── validating-decisioning-e2e-tests/
        └── SKILL.md
skills/validating-decisioning-e2e-tests -> ../plugins/addi-decisioning/skills/validating-decisioning-e2e-tests

Follows the same shape as every other plugin (security-engineer, debugging, code-review, etc.). Registered in .factory-plugin/marketplace.json under category qa and cross-linked from the root README.md.

Safety

• Read-only DB access — never issues INSERT/UPDATE/DELETE.
• Never edits Notion without explicit user confirmation — presents the verdict table first.
• Never persists the RDS IAM token — passed inline via PGPASSWORD and unset after the query.
• Fails loud on missing/expired token — asks the user for a fresh one instead of falling back to other credentials.

Install / Invoke

droid plugin marketplace add https://github.com/Factory-AI/factory-plugins
droid plugin install addi-decisioning@factory-plugins

Auto-activates when the user pastes a decisioning-e2e-quickpay-* Notion URL, or explicit via /validating-decisioning-e2e-tests.

Testing done

• Ran end-to-end against the Phase 2 (12 cases) and Phase 3 (10 cases) Notion pages on staging. Produced correct pass/fail verdicts; edge cases (missing loan/creditCheck nodes for REJECTED_BY_* scenarios, FGA 0.00 interpretation) are exercised in the rulebook.
• The skill previously lived in the AdelanteFinancialHoldings/platform monorepo under ai-native-backend-jvm/.agents/skills/ and is being upstreamed here unchanged.

[andriperalt]

Update CODEOWNERS so that Decisioning team owns the plugin

[mcsanchez-addi]

Done in ac6c9b9 — added .github/CODEOWNERS assigning plugins/addi-decisioning/ and the top-level skill symlink to @AdelanteFinancialHoldings/decisioning-approvers.

[andriperalt]

Why are you leaving this here outside the plugin?

[mcsanchez-addi]

Closing in favor of https://github.com/AdelanteFinancialHoldings/factory-addi-plugins/pull/39 — Addi is landing this plugin in the org-internal marketplace instead.