Repository navigation
feat(Flag Dependency): Support $.flags context values in segment conditions - #202
Merged
Merged
Conversation
…nditions Bump flagsmith-flag-engine to 11.1.1 so segments depending on other flags resolve, and evaluate `/flags` with segments that need no identity. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
khvn26
approved these changes
Nov 4, 2026
khvn26
left a comment
Member
There was a problem hiding this comment.
LGTM with a nit: I'd like us to return (and therefore test for) the reason field for both /flags and /identities, which I appreciate is out of scope for this PR.
Contributor
Author
Added to #204. |
emyller
pushed a commit
that referenced
this pull request
Nov 4, 2026
🤖 I have created a release *beep* *boop* --- ## [2.24.0](v2.23.0...v2.24.0) (2026-11-04) ### Features * **Flag Dependency:** Support `$.flags` context values in segment conditions ([#202](#202)) ([04794ae](04794ae)) * **Flags:** Return the `reason` field for both `/flags` and `/identities` ([#205](#205)) ([40a9ea9](40a9ea9)) * Send Flagsmith-identifying User-Agent to the Flagsmith API ([#203](#203)) ([3182eac](3182eac)) ### Dependency Updates * Bump flagsmith-flag-engine to 11.0.0 ([#198](#198)) ([2612bfd](2612bfd)) ### Other * **CI:** pre-commit autoupdate ([#191](#191)) ([137f311](137f311)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy ignores segments that target flags by other flags, and
/flagsapplies segments that need an identity, so it serves different flags than Flagsmith.Changes
/flagsand/identitiesapply overrides of segments that depend on other flags./flagsapplies overrides of segments reading$.environment, and ignores segments that need an identity.flagsmith-flag-engineto 11.1.1.Closes #199
Review effort: 2/5
🤖 Generated with Claude Code