Skip to content

feat: Retry event delivery and flush on close - #286

Closed
flagsmithsmith[bot] wants to merge 2 commits into
mainfrom
openhands/sdk-spec-v0.9.0
Closed

flagsmithsmith[bot] wants to merge 2 commits into
mainfrom
openhands/sdk-spec-v0.9.0

Conversation

@flagsmithsmith

Copy link
Copy Markdown
Contributor

Contributes to Flagsmith/sdk-spec#23

renovate Bot and others added 2 commits November 11, 2026 15:32
Its entry in Flagsmith/sdk-spec's compatibility matrix at v0.9.0: `core events local-evaluation`.
@flagsmithsmith flagsmithsmith Bot added the sdk-spec Bumps of the Flagsmith SDK behavioural spec label Nov 16, 2026
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ddc0fd27-7b42-4afe-bd24-aa8497f0e77a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codspeed

codspeed Bot commented Nov 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 15 untouched benchmarks


Comparing openhands/sdk-spec-v0.9.0 (53350cb) with main (14a8f5e)

Open in CodSpeed

@Zaimwa9

Zaimwa9 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

@flagsmithsmith what is the point of this PR ? #283

@flagsmithsmith

Copy link
Copy Markdown
Contributor Author

I made no changes here, because there was nothing left to fix: every check on this PR is green, including sdk-spec / Spec v0.9.0.

The v0.9.0 work is already on main. #283, which had the same title and branch, was squash-merged as 14a8f5e a minute before this PR was opened. 14a8f5e contains:

  • the spec bump to v0.9.0 with tags: core events local-evaluation
  • the SDK changes (event retries with backoff, flush(), and close() / stop())
  • their unit tests and the spec steps

This PR's branch was then reset to 53350cb, which holds only the two commits from before that work (the Renovate bump and the tags change). The spec check runs on the merge with main, so it tests main's implementation and passes.

So this PR adds nothing to main. Its diff only looks non-empty because GitHub compares it with the old merge base (b480743), from before #283. Only the workflow file changes there, and that change is already on main. I've left it open, because closing it is up to a maintainer.

@flagsmithsmith

Copy link
Copy Markdown
Contributor Author

Stuck: main already runs v0.9.0, so #286 isn't needed.

The SDK spec reconciler doesn't know what to do next here, so it has stopped working on this SDK. Once it's sorted, remove the openhands:stuck label and it'll look again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-spec Bumps of the Flagsmith SDK behavioural spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants