Repository navigation
feat(Tables): Open table filters as a popover, a bottom sheet on phones - #8997
Draft
talissoncosta wants to merge 2 commits into
Draft
talissoncosta wants to merge 2 commits into
talissoncosta wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
talissoncosta
force-pushed
the
feat/popover-bottom-sheet
branch
from
November 17, 2026 14:56
ee16aff to
9f9f33d
Compare
talissoncosta
force-pushed
the
feat/table-filter-popover
branch
from
November 17, 2026 15:23
765ebf0 to
77f46d5
Compare
talissoncosta
force-pushed
the
feat/popover-bottom-sheet
branch
from
November 17, 2026 15:23
9f9f33d to
4fcad7a
Compare
talissoncosta
force-pushed
the
feat/table-filter-popover
branch
from
November 17, 2026 15:27
77f46d5 to
cbf624f
Compare
talissoncosta
force-pushed
the
feat/popover-bottom-sheet
branch
from
November 17, 2026 15:27
4fcad7a to
85c4880
Compare
talissoncosta
force-pushed
the
feat/table-filter-popover
branch
from
November 17, 2026 15:33
cbf624f to
73a6ef1
Compare
TableFilter is built on Popover instead of InlineModal, so the feature list filters (Tags, Value, Users, Groups, View, Sort) open anchored on desktop and as a bottom sheet on phones, instead of a blank full-screen panel. - TableFilterOptions reuses TableFilter rather than duplicating the trigger and InlineModal. - Filters whose title carries a count take a label, so the sheet and the trigger's popup have a name. - Title, search and list share the same 16px indent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the Users filter passed size='lg' (a fixed 355px). The default already grows with its content up to 355px, and the phone sheet is full width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
talissoncosta
force-pushed
the
feat/table-filter-popover
branch
from
November 18, 2026 13:11
73a6ef1 to
a49bff4
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/if required so people know about the feature.Changes
Stacked on #8995. Independent of #8996.
The feature list filters (Tags, Value, Users, Groups, View, Sort) used
InlineModal, which a mobile rule stretches to a blank full-screen panel.TableFilternow usesPopover: anchored on desktop as before, a bottom sheet on phones.TableFilterOptionsreusesTableFilterinstead of duplicating the trigger andInlineModal.label(Tags, Value, Users, Groups), used as the sheet heading and the popup's name.Also used by the View filter in
FeatureFilters,FeatureImportandFeaturesTableFilters(no changes needed there).How did you test this code?