Skip to content

feat(Tables): Open table filters as a popover, a bottom sheet on phones - #8997

Draft
talissoncosta wants to merge 2 commits into
feat/popover-bottom-sheetfrom
feat/table-filter-popover
Draft

talissoncosta wants to merge 2 commits into
feat/popover-bottom-sheetfrom
feat/table-filter-popover

Conversation

@talissoncosta

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Stacked on #8995. Independent of #8996.

The feature list filters (Tags, Value, Users, Groups, View, Sort) used InlineModal, which a mobile rule stretches to a blank full-screen panel. TableFilter now uses Popover: anchored on desktop as before, a bottom sheet on phones.

  • TableFilterOptions reuses TableFilter instead of duplicating the trigger and InlineModal.
  • Filters whose title carries a count take a label (Tags, Value, Users, Groups), used as the sheet heading and the popup's name.
  • Title, search and list share the same 16px indent.

Also used by the View filter in FeatureFilters, FeatureImport and FeaturesTableFilters (no changes needed there).

How did you test this code?

  • 393px: Tags, Value, Users, Groups open as a full-width sheet with the right heading; Escape closes.
  • 1440px: Tags opens anchored under the trigger, stays open while ticking several tags, closes on a second click (the E2E archived-filter flow).
  • View and Sort on a phone.
  • Feature import screen's View filter.

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Nov 18, 2026 1:12pm UTC
flagsmith-frontend-staging Ready Ready Preview Nov 18, 2026 1:12pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 18, 2026 1:12pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request and removed feature New feature or request labels Nov 17, 2026
@github-actions github-actions Bot added the feature New feature or request label Nov 17, 2026
@talissoncosta
talissoncosta force-pushed the feat/popover-bottom-sheet branch from ee16aff to 9f9f33d Compare November 17, 2026 14:56
@talissoncosta
talissoncosta force-pushed the feat/table-filter-popover branch from 765ebf0 to 77f46d5 Compare November 17, 2026 15:23
@talissoncosta
talissoncosta force-pushed the feat/popover-bottom-sheet branch from 9f9f33d to 4fcad7a Compare November 17, 2026 15:23
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Nov 17, 2026
@talissoncosta
talissoncosta force-pushed the feat/table-filter-popover branch from 77f46d5 to cbf624f Compare November 17, 2026 15:27
@talissoncosta
talissoncosta force-pushed the feat/popover-bottom-sheet branch from 4fcad7a to 85c4880 Compare November 17, 2026 15:27
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Nov 17, 2026
@talissoncosta
talissoncosta force-pushed the feat/table-filter-popover branch from cbf624f to 73a6ef1 Compare November 17, 2026 15:33
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Nov 17, 2026
talissoncosta and others added 2 commits November 18, 2026 10:07
TableFilter is built on Popover instead of InlineModal, so the feature list
filters (Tags, Value, Users, Groups, View, Sort) open anchored on desktop and
as a bottom sheet on phones, instead of a blank full-screen panel.

- TableFilterOptions reuses TableFilter rather than duplicating the trigger
  and InlineModal.
- Filters whose title carries a count take a label, so the sheet and the
  trigger's popup have a name.
- Title, search and list share the same 16px indent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the Users filter passed size='lg' (a fixed 355px). The default already
grows with its content up to 355px, and the phone sheet is full width.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-staging — a49bff4d Deployed Nov 18, 2026 by vercel[bot]
Preview – flagsmith-frontend-preview — a49bff4d Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant