You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[WIP] test(Identities): Cover the identities list, identity page, traits and overrides - #9011
talissoncosta
changed the title
test(Identities): Cover the identities list, identity page, traits and overrides
[WIP] test(Identities): Cover the identities list, identity page, traits and overrides
Nov 18, 2026
Adds Playwright end-to-end tests for identity creation, search, and deletion. The tests also cover direct identity page loads, trait editing, and per-identity feature-flag overrides. Each test logs in and creates a uniquely named project.
This PR adds end-to-end test coverage for identities and makes no production code changes. It carries no meaningful merge risk, though the PR title should be fixed to satisfy the conventional commit check.
Finishing Touches
Fix failing CI checks
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 1 file
Confidence score: 4/5
In identities-test.pw.ts, checking only that the effective value is off can miss an override that is still active. Also verify the override description or Reset control disappears after reset.
The tests in identities-test.pw.ts omit the required # Given, # When, and # Then sections. Add them to make setup, actions, and outcomes explicit.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="frontend/e2e/tests/identities-test.pw.ts">
<violation number="1" location="frontend/e2e/tests/identities-test.pw.ts:40">
P3: These tests omit the required `# Given`, `# When`, and `# Then` sections. Add those sections to each test body to make setup, actions, and outcomes explicit.</violation>
<violation number="2" location="frontend/e2e/tests/identities-test.pw.ts:109">
P2: This only confirms the effective value is off; an off-valued identity override would pass while still overriding the environment. Also assert that the override description or Reset control disappears after reset.</violation>
</file>
Reply with feedback, questions, or to request a fix.
The reason will be displayed to describe this comment to others. Learn more.
P2: This only confirms the effective value is off; an off-valued identity override would pass while still overriding the environment. Also assert that the override description or Reset control disappears after reset.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At frontend/e2e/tests/identities-test.pw.ts, line 109:
<comment>This only confirms the effective value is off; an off-valued identity override would pass while still overriding the environment. Also assert that the override description or Reset control disappears after reset.</comment>
<file context>
@@ -0,0 +1,126 @@
+ await identityLink(page, 'dave_e2e').click()
+
+ log('The flag starts off, as in the environment')
+ await helpers.waitForUserFeatureSwitch('identity_flag', 'off')
+
+ log('Turn it on for this identity only')
</file context>
The reason will be displayed to describe this comment to others. Learn more.
P3: These tests omit the required # Given, # When, and # Then sections. Add those sections to each test body to make setup, actions, and outcomes explicit.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At frontend/e2e/tests/identities-test.pw.ts, line 40:
<comment>These tests omit the required `# Given`, `# When`, and `# Then` sections. Add those sections to each test body to make setup, actions, and outcomes explicit.</comment>
<file context>
@@ -0,0 +1,126 @@
+ }
+}
+
+test.describe('Identities', () => {
+ test('Identities can be created, searched and deleted @oss', async ({
+ page,
</file context>
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 440b63fd-71ad-4b71-b19e-c78204c1cb47
Commits
Reviewing files that changed from the base of the PR and between d465e74 and 5dbad22.
Files selected for processing: 1
frontend/e2e/tests/identities-test.pw.ts
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
The final assertion also passes if reset leaves a disabled identity override. The override description depends on override ownership, not the enabled value. (raw.githubusercontent.com)
After the switch becomes off, assert that This feature is being overridden for this identity is hidden. This strengthens the reset coverage before the migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
front-endIssue related to the React Front End Dashboard
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Adds E2E coverage for identities ahead of moving the identity page from Flux to RTK Query, so the migration has a safety net.
Each test uses its own project and accessible selectors (no new
data-test).How did you test this code?