Skip to content

test(Lint): Check the review lint rules warn in CI - #9012

Closed
talissoncosta wants to merge 12 commits into
mainfrom
test/lint-review-rules-ci
Closed

talissoncosta wants to merge 12 commits into
mainfrom
test/lint-review-rules-ci

Conversation

@talissoncosta

Copy link
Copy Markdown
Contributor

Throwaway check for #8819, never merge. I'll close it once CI has run.

Changes

  • LintRulesCheck.tsx breaks each rule once, so CI should show 12 warnings and 0 errors. as const and a style that only sets --w should not warn.
  • IdentitiesPage.tsx gains one comment line. Its existing data-test lines are untouched, so they should not warn.

How did you test this code?

Locally, with the pre-commit hook's LINT_STAGED: 12 warnings, 0 errors, none in IdentitiesPage.tsx. This PR checks the same in CI, and whether the warnings show anywhere besides the job log.

talissoncosta and others added 12 commits November 16, 2026 15:44
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ents

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… names

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Throwaway, never merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Nov 18, 2026 7:16pm UTC
flagsmith-frontend-staging Ready Ready Preview Nov 18, 2026 7:16pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 18, 2026 7:16pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@talissoncosta

Copy link
Copy Markdown
Contributor Author

Served its purpose: the #8819 rules warn in CI as expected (12 warnings, 0 errors, annotated inline).

@talissoncosta
talissoncosta deleted the test/lint-review-rules-ci branch November 18, 2026 19:28

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-staging — 73412bef Deployed Nov 18, 2026 by vercel[bot]
Preview – flagsmith-frontend-preview — 73412bef Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant