Repository navigation
fix(Onboarding): Keep new users on the flow they were assigned - #9017
Draft
talissoncosta wants to merge 3 commits into
Draft
talissoncosta wants to merge 3 commits into
talissoncosta wants to merge 3 commits into
Conversation
A reload before onboarding had created the organisation logged in again without isGettingStarted, so a single_page user was sent to /create. Submitting it opened the onboarding flow, which read a stale organisation list and created a second organisation. Route by the stored variant when there is one, and wait for the organisation list to finish refetching before onboarding creates one. The E2E test pins the variant so it runs whatever the flag is set to. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The onboarding_variant trait was set on /getting-started. Single-page users reach it straight after signup, but control users only after /create, so control users who left on /create were never labelled. Set it where the variant is resolved instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9017 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 1713 1713
Lines 72566 72566
=======================================
Hits 71789 71789
Misses 777 777 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Session replays showed new users on "Create your organisation" and then the new onboarding, ending with two organisations.
Cause: a reload before onboarding has created the organisation logs in again without
isGettingStarted, so asingle_pageuser is sent to/create. Submitting it opens onboarding, which reads a stale organisation list and creates a second one.onboarding_varianttrait is sent at the decision for both arms. It was set on/getting-started, which control users only reach after/create, so control drop-offs there were never labelled.Doesn't change bucketing, exposure or the control flow.
How did you test this code?
resolveOnboardingVariant./create, then the legacy page, one organisation, trait sent before/create.single_pagesignup with a reload before the organisation exists: stays on onboarding, one organisation./create, no trait.