Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CachedAsyncImagenow accepts a custom view while an image loads.init(url:)keeps the existingProgressViewplaceholder.This is not a cache bug fix. The existing cache already shared one
NSCache; its singleton and storage behavior remain unchanged. The non-generic cache stays outside the view so different placeholder types share it. Swift 6.4.2 rejects a static stored singleton in a type nested under a generic view. This does not prevent nesting the loader. The loader remains nested in the view; its phase stays nested in the loader. The platform image alias belongs toCachedAsyncImageCache.Image.Keeping one cache avoids storing the same downloaded image separately for each placeholder type.
Evidence
CachedAsyncImageTestspassed, including both placeholder initializers and cache reuse across different placeholder types.static stored properties not supported in generic types.Merge Danger
Door: one-way – public generic type change.
Blast Radius: consumers
CachedAsyncImage(url:)remains available. Explicit annotations such aslet image: CachedAsyncImageneed a placeholder type argument.The internal nesting correction changes no public signature. Its code review covers only that correction, not approval of the whole PR.