Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle errors inside the three discarded throwing tasks in
AsyncButtonandWebView. This removes threeNoUseUnstructuredThrowingTaskdiagnostics without changing public APIs.Local catches keep each failure next to its operation. A shared helper would add an abstraction for only three sites. Existing task ownership and the outer
catchErrorcallback remain unchanged.Evidence
Before: the baseline build completed with three target diagnostics.
After: the build completed with zero target diagnostics. The existing suite passed: 37 tests in 13 suites.
Independent runtime checks on macOS 27.2 confirmed success/failure feedback and its approximately two-second reset. Each failure activation called
catchErroronce. Removing a cooperative running button delivered cancellation once. A local page scrolled to Y=600. A page whosescrollBythrows stayed alive and logged its error as<private>.These are post-change captures, not a historical visual comparison. The before/after evidence is the compiler diagnostic count.
Build and tests ran sequentially through
simlease, usingswift build/swift test --build-system swiftbuild --jobs 1with an isolated scratch path. Reviewed and exercised commit:81178270920902dd27bf707d9644af70751a7426.Larger-font rendering was attempted but not verified. Not checked: internal timer/scroll-task cancellation, keyboard/VoiceOver, other platforms, or release readiness. The repository has no
CODING_STANDARDS.md; code review used the available workspace and Swift rules. No new regression tests were added. No browser rendering check ran. Review: Code ✓ · Design – (no visual redesign) · QA ✓ (specified macOS flows only).Merge Danger
Door two-way · Blast Radius local (feedback timers and delayed page scroll).
Public APIs and task ownership are unchanged. The detector reported exit 0. It assumes a local radius because the repository has no
BlastRadius.md.