Repository navigation
Conversation
added 2 commits
October 21, 2026 12:18
Specs left state behind (device groups, pipelines, devices, a rolled back instance, a deactivated stack, a removed team member) that later specs relied on not being there, and the EE environment did not await the RBAC fixtures. Each spec now cleans up after itself or targets its own data, instance state no longer depends on which spec loads it first, and the developer mode and admin navigation races are waited on.
devices/bulk.spec.js deletes one of the application-2 devices, so the fixed count failed whenever it ran first.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9012 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 475 475
Lines 26018 26018
Branches 6934 6934
=======================================
Hits 20674 20674
Misses 5344 5344
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…tance The closing application options stay in the DOM during their leave transition, so the instance name could be read from them, failing the test after the device was assigned. Each test now also starts with the device unassigned, so one failure no longer fails its retries and devices/assignment.spec.js.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several Cypress specs only passed because of the order the suite runs them in. They relied on state an earlier spec had or had not created, so moving, sharding or running a spec on its own could make it fail. This makes every spec independent of run order, which is needed before the UI jobs can be sharded (#9006).
EE
applications/pipelinesleft a device group and pipeline behind, which brokeapplications/device-groups. It now deletes them at the end of the test.instance-2-with-devicesis never started, so its stored state stayedrunninguntil a page polled the driver and rewrote it tounknown. The environment now storesunknownup front, andapplications/applicationsexpects 1 running and 1 stopped instance.rbacTeamFactorywas not awaited, so the first spec could run before the RBAC fixtures existed. It is now awaited.devices/developer-modecould start while a device was still in developer mode from the previous test.beforeEachnow puts BTeam devices back into fleet mode.OS
5.
team/team-membershipremoved the member in the third row, which was dashboard-dave in some orders and brokebrokers/clientsandbrokers/hierarchy. It now removes charlie by name.6.
devices/assignmentleftnew-device-*devices in application-2, which brokeapplications/devices. They are now deleted inafter().7.
applications/devicesexpected exactly 3 devices, butdevices/bulkdeletes one of them. It now compares against the API count.8. The rollback test in
instances/version-history/snapshotsreally rolled backinstance-1-1and removed its dashboard module, which broketeam/instances. The rollback response is now stubbed, since the test only checks the request.9.
team/instancesdid not wait for the dashboard instances request before asserting on the table. It now does.10.
admin/stacksversioned and deactivatedstack1, whichinstance-1-1uses, and that brokeinstances. A new unusedstack-to-replacefixture is versioned instead.11.
admincould lose the navigation click when it was made before the team overview had loaded. Both admin tests now wait for it.Items 4, 9 and 11 also cover flakes reported in #8478.
Testing
Each suite was run with retries disabled, in a container limited to the same 4 CPUs as a GitHub runner:
No workflow changes. Sharding follows in #9006.
Closes #9004
Closes #9005