Repository navigation
feat: consume coding-agent-kit v0.3.0 and preview account details in fzf-tab - #5
Merged
Merged
Conversation
A new minor release, so a reviewed bump rather than the daily patch run. v0.3.0 keeps last-seen account details offline and adds --account-info and --account-labels; claude-as now passes its child CODING_AGENT_KIT_USAGE_FILE and CODING_AGENT_KIT_TOKEN_ID. Every test entry point and tests/run.ps1 unset those two and XDG_STATE_HOME, so a caller's session never reaches a suite (the delivery knob gate requires the two kit names).
The fzf-tab preview of codex-as and claude-as now shows the kit's offline --account-info for an account (last-seen email or label, plan and usage) and the word itself for any other argument, so a credential path still never reaches the generic file preview. fzf-tab looks this context up by command only (the completions call _describe without _arguments), so the group, the [%d] description, tells an account from an argument; a failing query falls back to the word. The old test evaluated the zstyle under a context fzf-tab never uses. The new hermetic case uses the real one, and a second case drives real fzf-tab (FZF_TAB_TEST_DIR) in an interactive zsh with a fake fzf that runs fzf-tab's own preview command per candidate; both fail against the old zstyle. Docs describe the account details and the privacy trade-off.
pty imports termios, which native Windows Python lacks, so importing test_ai_integration failed there and the Windows CI job lost the whole module. The one case that needs pty is skipped on Windows and now imports it itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consumes coding-agent-kit v0.3.0 (FridrichMethod/coding-agent-kit#2, tag v0.3.0 on 081f54a) and shows account details in the fzf-tab completion preview. It builds on #4 (merged), the kit's own Stow package.
chore(deps): update coding-agent-kit submodule to v0.3.0.tests/run.ps1also unsetCODING_AGENT_KIT_USAGE_FILE,CODING_AGENT_KIT_TOKEN_IDandXDG_STATE_HOME. The delivery knob gate requires the two kit names.feat(zsh): preview account details in fzf-tab completion.custom/fzf-tab.zshpreviews acodex-asorclaude-asaccount with--account-info NAME, offline and without opening a credential.$group([Codex accounts],[Claude accounts]), because the launchers' completions have no per-tag context.fix(tests): import pty only in the real fzf-tab case.import ptyneedstermios, which Windows Python lacks, sotest_ai_integrationcould not be imported there.bootstrap-e2eran on commit 2 and passed; commit 3 changes only that test import.Verified (lab clones, push disabled, temporary homes)
tests/run.sh --ci, the pwsh suites andpre-commit run --all-filespass on each commit alone.e2e-harness-windowsfails only in the lab, from its long TMPDIR, as on refactor(coding-agent-kit): give the kit its own Stow package #4.FZF_TAB_TEST_DIRand skips without it.fzf-tab.zsh, plus the two new--helplines.Not verified here
e2e-ci/**run are the gate.