Repository navigation
Conversation
…ong across requests
…ctor-async imports it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base
feat/db-interface-async(#9), withfeat/db-interface-kv(#10) merged in. Until #10 merges, this diff also shows thekv-types+kv-synccommits. The new parts are the merge and09f4443.deps/db/kv.wit: interfacegcore:db/kv, the async variant ofkv-sync.database.execute(op)andbatch(ops)returnfuture-op-result/future-batch-result(subscribe() -> pollable,get(), result returned once).openstays synchronous. Reuseskv-typesop/op-result.world reactor-asyncimportsgcore:db/kv@0.1.0besidegcore:db/sql;world reactoris unchanged (kv-sync).The WIT documents the ordering rule: calls already started run independently. Read-your-writes holds for a call started after an earlier call's result is ready. Dropping a future abandons the result, and the operation may or may not have been applied.
Decisions needed
execute(op)instead of a method per opKvBackend::execute. The SDKs keepget,set, ... on topPromise.allof 3 gets takes 48 ms, against 147 ms awaited in turnEngine design + measurements:
docs/db/KV_ASYNC.mdin G-Core/FastEdge (branchfeat/db-interface-kv-async).Related: #9 (base), #10 (merged in), G-Core/FastEdge#662, G-Core/FastEdge-sdk-js#159