Repository navigation
fix(xlsx): read valueless <c ...></c> cells as empty; promote v7.4.0 public API; dependency bumps - #176
Merged
Conversation
Bumps [rust_xlsxwriter](https://github.com/jmcnamara/rust_xlsxwriter) from 0.101.0 to 0.102.0. - [Changelog](https://github.com/jmcnamara/rust_xlsxwriter/blob/main/CHANGELOG.md) - [Commits](jmcnamara/rust_xlsxwriter@v0.101.0...v0.102.0) --- updated-dependencies: - dependency-name: rust_xlsxwriter dependency-version: 0.102.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps Meziantou.Analyzer from 3.0.317 to 3.0.320 --- updated-dependencies: - dependency-name: Meziantou.Analyzer dependency-version: 3.0.320 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: analyzers ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps Microsoft.Testing.Extensions.TrxReport from 2.5.1 to 2.5.2 --- updated-dependencies: - dependency-name: Microsoft.Testing.Extensions.TrxReport dependency-version: 2.5.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: test ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps OfficeIMO.Excel from 3.5.2 to 3.5.3 --- updated-dependencies: - dependency-name: OfficeIMO.Excel dependency-version: 3.5.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: benchmarks ... Signed-off-by: dependabot[bot] <support@github.com>
…-api-v7.4.0 chore: promote public API for v7.4.0
…ts/ExcelReader.Benchmarks/develop/benchmarks-d8f816df1a Bump the benchmarks group with 1 update
…elop/analyzers-7445cc1560 Bump the analyzers group with 1 update
…ts/ExcelReader.NetFramework.Tests/develop/test-94d1d3d3af Bump the test group with 1 update
…t/develop/rust_xlsxwriter-0.102.0 build(deps): bump rust_xlsxwriter from 0.101.0 to 0.102.0 in /rust
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #176 +/- ##
==========================================
- Coverage 92.39% 92.39% -0.01%
==========================================
Files 294 294
Lines 24935 24938 +3
Branches 4041 4042 +1
==========================================
+ Hits 23039 23041 +2
Misses 1292 1292
- Partials 604 605 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Everything on
developsincev7.4.0: one reader fix, the post-release PublicAPI promotion, and four Dependabot bumps.XLSX: open-and-closed empty cells (
XlsxWorkbook.Enumerator.cs)openpyxl writes a styled cell with no value as
<c r="A1" s="1" t="n"></c>, not as<c r="A1" s="1"/>. The self-closing form already read asEmpty. The open-and-closed form went intoEmitScalarValuewith an empty span, which gave aNumber/Date/Boolean/Errorcell with empty text and no number.Formula and string kinds are unchanged. An empty string is still a real value for them.
Other commits
chore: promote public API for v7.4.0: moves the 7.4.0 entries fromPublicAPI.Unshipped.txttoPublicAPI.Shipped.txt(144 + 301 lines). Analyzer metadata only, no API change.rust_xlsxwriter0.101.0 → 0.102.0 (rust/excelreader)Meziantou.Analyzer3.0.317 → 3.0.320 (Directory.Build.props)Microsoft.Testing.Extensions.TrxReport2.5.1 → 2.5.2 (NetFramework tests)OfficeIMO.Excel3.5.2 → 3.5.3 (benchmarks)Evidence
New
PythonProducerFixturescase inXlsxProducerDialectShapeTests:Datewith empty text, C1 →Booleanwith empty textAfter: A1 →
Empty, B1 →Number "2", C1 →Empty, D1 →ExcelString "openpyxl"Merge Danger
Door: two-way
A revert is enough to undo it. Nothing is persisted or migrated.
Blast Radius: XLSX reader
A consumer that read these cells and checked for
Number/Date/Booleanwith empty text now getsEmpty, which is what<c .../>already returned. No other format and no writer is touched. The analyzer bump could add new build warnings but cannot change runtime behaviour.