Repository navigation
Conversation
Pushes sent while the socket was down are lost, so a guest can sit on a stale slot table. Refresh the lobby from the service on reconnect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lobby pushes sent while the socket was down are gone for good. A guest that missed one sits on a stale slot
table until the next push, and a host waiting on that guest's acknowledgement waits forever. On a reconnect
while in a lobby, refresh the lobby from the service with the existing
UpdateRoomDataCache.Ten lines in
WebSocket::Tick, inside the existing "Re-Connected" branch. Seen on our online nights after thejittered-backoff reconnect landed: the reconnect itself worked, the lobby state after it did not.