Figure.sac: Plot seismograms in SAC format - #4854
Open
Chuan1937 wants to merge 8 commits into
Open
Conversation
Chuan1937
changed the title
16 tasks
seisman
reviewed
Aug 24, 2026
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Aug 26, 2026
Comment on lines
+115
to
+122
| fill | ||
| Paint the positive or negative portion of the traces. Use ``p``/``n`` to | ||
| paint the positive/negative portion [Default paints the positive | ||
| portion], ``+g`` *fill* to set the fill color [Default is ``"black"``], | ||
| ``+z`` *zero* to define the zero line, and ``+t`` *t0*/*t1* to paint a | ||
| time window only. Can be repeated to paint the positive and negative | ||
| portions separately, e.g., ``["p+gblack", "n+gred"]``. Set to ``True`` | ||
| to paint the positive portion with the default fill. |
Member
There was a problem hiding this comment.
This parameter is not Pythonic yet.
seisman
reviewed
Sep 4, 2026
Comment on lines
+104
to
+109
| Choose the profile type, i.e., the type of the y axis. Use ``a`` for | ||
| azimuth, ``b`` for back-azimuth, ``k`` for epicentral distance in km, | ||
| ``d`` for epicentral distance in degrees, ``n`` for trace number (the | ||
| first trace is numbered *n*, e.g., ``n0``), and ``u`` for user-defined | ||
| profile (the y positions are determined by the SAC header variable | ||
| ``usern``, e.g., ``u0``). |
Member
There was a problem hiding this comment.
Maybe support more readable arguments like: azimuth, back_azimuth, distance_in_km, distance_in_degree, number, user0, ..., user9?
Member
There was a problem hiding this comment.
Maybe we can check which names ObsPy is using and use the same names here.
Member
There was a problem hiding this comment.
These single letters correspond to the following SAC header variables:
a:azb:bazk:distdistance in kmd:gcarcgreat-circle distance in degreesn: just trace numberu0:user0u9:user9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request wraps the module
sac.Preview at https://pygmt-dev--4854.org.readthedocs.build/en/4854/api/generated/pygmt.Figure.sac.html