Repository navigation
feat(contacts): --dry-run and --on-conflict on contacts import and import-csv - #69
Merged
Merged
Conversation
…port-csv Both import commands take `--dry-run` (the API's `dryRun: true`: the response the import would return, nothing written) and `--on-conflict upsert|skip` (`skip` leaves existing contacts unchanged). An unknown mode is a usage error. The terminal summary of a dry run says "Dry run — nothing was written" and counts what it would add, update, fail and skip. The SDK pin moves to the commit that types both options (GetBrew/typescript-sdk claude/contact-import-dry-run), and the vendored spec and generated types are synced from GetBrew/brew-v2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- SDK pin -> 3ff0329 (sdk#79 head with the base merged), bun.lock from a real install, RELEASING gate SHA updated. - A real run without importId no longer prints "as undefined". - Tests: dry run requested through --input, invalid --on-conflict on contacts import, a real envelope for the import dry-run case. - CHANGELOG wording for the dry-run summary and importId. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
thedogwiththedataonit
marked this pull request as ready for review
October 21, 2026 10:37
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…ude/contact-import-dry-run
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A body's dryRun/onConflict reach the request unchanged when no flag is given, and --on-conflict overrides a conflicting body value (contacts import and import-csv); the --input dry-run test asserts the request too. Greptile on 2bec9ce. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ws get --kind - Re-vendor the spec from brew-v2 main 87ac2c6242 (#2220 merged) and pin the SDK at its #79 head (a02b304) until the release. - flows get takes a <domain>/<kind> slug and --kind, via the SDK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # RELEASING.md # bun.lock # package.json
thedogwiththedataonit
changed the base branch from
claude/contact-imports
to
main
October 24, 2026 18:38
flagString read an empty value as unset, so --on-conflict "" (an unset shell variable) ran an upsert. Every supplied value is checked first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #65 (base
claude/contact-imports). App PR: GetBrew/brew-v2#2220; SDK PR: GetBrew/typescript-sdk#79.contacts importandcontacts import-csvtake--dry-runand--on-conflict upsert|skip(shared insrc/commands/contacts/import-modes.ts; an unknown mode is a usage error, exit 2). An absent flag leaves a value from--inputor the file alone.import-summary.ts) of a dry run readsDry run of contacts.csv — nothing was written: 1 to add, 0 to update, 0 to fail, 1 to skip (2 rows submitted).and "Custom fields it would create";CONTACT_EXISTS_SKIPPEDrows show in the WARNINGS table.1e11f3f(sdk#79 head, with the base merged through25f8e1e;bun.lockfrom a real install; RELEASING gate SHA updated), vendored spec + generated types synced, command docs regenerated, CHANGELOG.Checks:
bun run test697/697 (incl. parity),tsc --noEmitclean, biome clean, command docs fresh. A real run withoutimportIdprints no "as undefined". Needs the matching API deployment.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.
The PR appears safe to merge with the matching API deployment.Summary
Adds
--dry-runand--on-conflictto both contact import commands, with preview summaries, updated API types, and command docs.--kind.Reviews (6) · Last reviewed commit: "fix(contacts): an empty --on-conflict st..." · Reviewed by Greptile