Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
flu-1093-tapping-the-message-list-doesnt-dismiss-the-composers
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3118 +/- ##
==========================================
+ Coverage 80.28% 80.38% +0.10%
==========================================
Files 455 455
Lines 29614 29619 +5
==========================================
+ Hits 23775 23809 +34
+ Misses 5839 5810 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…earing them (FLU-1093) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
VelikovPetar
approved these changes
Oct 27, 2026
…ing-the-message-list-doesnt-dismiss-the-composers # Conflicts: # e2e_app/README.md # e2e_app/fastlane/Fastfile # e2e_app/integration_test/authentication_test.dart # e2e_app/integration_test/giphy_test.dart # e2e_app/integration_test/hyper_links_test.dart # e2e_app/integration_test/message_actions_test.dart # e2e_app/integration_test/message_delivery_status_test.dart # e2e_app/integration_test/message_list_test.dart # e2e_app/integration_test/pages/channel_list_page.dart # e2e_app/integration_test/robots/backend_robot.dart # e2e_app/integration_test/robots/participant_robot.dart # e2e_app/integration_test/robots/user_robot.dart # e2e_app/integration_test/robots/user_robot_message_list_asserts.dart # e2e_app/integration_test/support/stream_test_env.dart # e2e_app/lib/auth/auth_controller.dart # e2e_app/lib/pages/channel_list_tab.dart # e2e_app/lib/pages/choose_user_page.dart # e2e_app/lib/pages/home_page.dart # e2e_app/lib/pages/thread_list_tab.dart # e2e_app/lib/widgets/e2e_message_actions.dart # e2e_app/lib/widgets/search_text_field.dart # e2e_app/pubspec.yaml # packages/stream_chat_flutter/CHANGELOG.md
xsahil03x
deleted the
sahil/flu-1093-tapping-the-message-list-doesnt-dismiss-the-composers
branch
October 27, 2026 23:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Typing
/or@opens suggestions above the composer. They already close when the field loses focus or the list is dragged. On Android and iOS, though, a touch tap on the message list doesn't unfocus a text field, so the suggestions stayed open until the trigger was deleted.StreamAutocompletenow puts the field and its suggestions in one tap group. A tap outside both hides the suggestions, the same way losing focus already does, without clearing them. The field keeps focus and the keyboard stays up, as on iOS UIKit. The next keystroke, or refocusing the field on desktop, shows them again. Desktop, web and mouse input already unfocus on a tap outside, so they behave as before.This also enables "command suggestions disappear when the user taps on the message list" in
message_list_test.dart.Fixes FLU-1093.
Stacked on #3105 (the e2e suite); GitHub retargets it to
masteronce that merges.Verification
message_composer_command_suggestions_test.dart:The tap-outside, suggestion and desktop tests each fail without their part of the change; the keystroke test guards against hiding them for good. The same tests also pass compiled for and run in Chrome, where a tap outside unfocuses the field as Flutter does on web.
The message input, autocomplete, message list and channel suites pass; only the local macOS goldens fail.
Android emulator: typed
/, tapped the message list. Before, the suggestions stayed. After, they close and the keyboard stays.e2e: the test is un-skipped and runs in this PR's E2E workflow.
v11: see the "Merging master into v11" comment on FLU-1093.
🤖 Generated with Claude Code